fix: convert metered tier upTo from internal to display credits in listPlans

[FelixMalfait]

Summary

• The listPlans GraphQL query was returning metered tier upTo values in internal credit units (1000x the display value), causing "Credits by period" and "Credit Plan" dropdowns to show "50M" instead of "50k"
• Applied the existing INTERNAL_CREDITS_PER_DISPLAY_CREDIT (1000) divisor in formatBillingDatabasePriceToMeteredPriceDTO, matching the conversion already used in getMeteredProductsUsage resolver
• Updated frontend mock data to reflect the corrected display-unit values

Test plan

• Unit tests pass for format-database-product-to-graphql-dto.util
• Unit tests pass for metered-credit.service and billing-credit-rollover.service
• Verify billing page shows correct credit amounts (50k, not 50M) for "Credits by period" and "Credit Plan"

Made with Cursor

[greptile-apps]

Greptile Summary

Fixes a display bug where metered tier upTo values were shown as internal credit units (1000x too large). Applied the existing INTERNAL_CREDITS_PER_DISPLAY_CREDIT divisor in formatBillingDatabasePriceToMeteredPriceDTO, matching the conversion already used in the getMeteredProductsUsage resolver.

Key changes:

• Converts database tier up_to values (e.g., 50000000) to display units (50000) by dividing by 1000
• Updates frontend mock data to reflect corrected display values
• Adds test coverage for the internal-to-display credit conversion
• Preserves null values correctly (infinite tier boundary)

This ensures consistency across the billing system where all credit values exposed through GraphQL use display units, fixing the UI bug showing "50M" instead of "50k" in "Credits by period" and "Credit Plan" dropdowns.

Confidence Score: 5/5

• This PR is safe to merge - it's a straightforward bug fix with proper test coverage
• The fix correctly applies an existing constant (INTERNAL_CREDITS_PER_DISPLAY_CREDIT) that's already used elsewhere in the codebase. The implementation properly handles both numeric and null values, includes comprehensive test coverage, and updates mock data consistently. The change is isolated to a single formatting function with no side effects.
• No files require special attention

Important Files Changed

Filename	Overview
packages/twenty-server/src/engine/core-modules/billing/utils/format-database-product-to-graphql-dto.util.ts	Adds INTERNAL_CREDITS_PER_DISPLAY_CREDIT conversion (÷1000) to metered tier upTo values, fixing display bug
packages/twenty-front/src/testing/mock-data/billing-plans.ts	Updates mock tier upTo values from internal (÷1000) to match corrected display values
packages/twenty-server/src/engine/core-modules/billing/utils/tests/format-database-product-to-graphql-dto.util.spec.ts	Updates existing test data and adds dedicated test for internal-to-display credit conversion

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Database: up_to = 50000000] --> B[formatBillingDatabasePriceToMeteredPriceDTO]
    B --> C{tier.up_to !== null?}
    C -->|Yes| D[Math.round up_to / 1000]
    C -->|No| E[Return null]
    D --> F[GraphQL DTO: upTo = 50000]
    E --> F
    F --> G[Frontend: tiers 0 .upTo]
    G --> H[MeteredPriceSelector: formatNumber upTo]
    G --> I[SettingsBillingSubscriptionInfo: formatNumber upTo]
    H --> J[Display: 50k Credits]
    I --> K[Display: Credits by period: 50k]

Loading

_{Last reviewed commit: e0b07b6}

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/twenty-server/src/engine/core-modules/billing/utils/format-database-product-to-graphql-dto.util.ts">

<violation number="1" location="packages/twenty-server/src/engine/core-modules/billing/utils/format-database-product-to-graphql-dto.util.ts:48">
P2: This conversion rounds to a whole number, which loses the 1‑decimal display precision used elsewhere (toDisplayCredits). If tier.up_to isn’t an exact multiple of 1000, the tier thresholds will be rounded up/down (e.g., 7.5 → 8). Use the shared toDisplayCredits helper for consistent display units.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:43573

This environment will automatically shut down when the PR is closed or after 5 hours.

[FelixMalfait]

@claude fix lint and typecheck, then push to this branch

❌ > nx run twenty-server:typecheck

tsgo -p tsconfig.json

Error: src/engine/core-modules/billing/utils/tests/format-database-product-to-graphql-dto.util.spec.ts(152,12): error TS18047: 'meteredPrices' is possibly 'null'.
Error: src/engine/core-modules/billing/utils/tests/format-database-product-to-graphql-dto.util.spec.ts(155,12): error TS18047: 'meteredPrices' is possibly 'null'.

tsgo -p tsconfig.json

Error: src/engine/core-modules/billing/utils/tests/format-database-product-to-graphql-dto.util.spec.ts(152,12): error TS18047: 'meteredPrices' is possibly 'null'.
Error: src/engine/core-modules/billing/utils/tests/format-database-product-to-graphql-dto.util.spec.ts(155,12): error TS18047: 'meteredPrices' is possibly 'null'.
Warning: command "tsgo -p tsconfig.json" exited with non-zero status code::endgroup::
❌ > nx run twenty-server:lint:ci

Linting "twenty-server"...
(node:4194) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use node --trace-deprecation ... to show where the warning was created)

/home/runner/work/twenty/twenty/packages/twenty-server/src/engine/core-modules/billing/utils/format-database-product-to-graphql-dto.util.ts
46:14 error Delete ⏎········· prettier/prettier

[claude]

Claude finished @FelixMalfait's task in 1m 52s —— View job

---

Fixed lint and typecheck errors

• Fix TypeScript error: 'meteredPrices' is possibly 'null' in test file (lines 152, 155) — added non-null assertions
• Fix Prettier formatting error in util file (line 46) — collapsed multi-line ternary to single line
• Run lint and typecheck to verify — both pass
• Push to branch

View commit ·

[twenty-eng-sync]

Hey @FelixMalfait! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!