Update updatedat field on dashboards after edition

[bosiraphael]

Closes twentyhq/core-team-issues#1896

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[cubic-dev-ai]

1 issue found across 11 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-server/src/engine/metadata-modules/dashboard/services/dashboard-sync.service.ts">

<violation number="1" location="packages/twenty-server/src/engine/metadata-modules/dashboard/services/dashboard-sync.service.ts:46">
P2: Error logging loses stack trace. When concatenating `${error}` into the message string, the stack trace is lost. Consider passing the stack trace as a separate argument to preserve debugging information.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: Error logging loses stack trace. When concatenating ${error} into the message string, the stack trace is lost. Consider passing the stack trace as a separate argument to preserve debugging information.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-server/src/engine/metadata-modules/dashboard/services/dashboard-sync.service.ts, line 46:

<comment>Error logging loses stack trace. When concatenating `${error}` into the message string, the stack trace is lost. Consider passing the stack trace as a separate argument to preserve debugging information.</comment>

<file context>
@@ -0,0 +1,110 @@
+      );
+    } catch (error) {
+      this.logger.error(
+        `Failed to update dashboard updatedAt for page layout ${pageLayoutId}: ${error}`,
+      );
+    }
</file context>

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:2496

This environment will automatically shut down when the PR is closed or after 5 hours.

[Weiko]

Don't we want to actually destroy the dashboard in this case?

[bosiraphael]

It is already handled: in the page layout service

if (flatPageLayoutToDestroy.type === PageLayoutType.DASHBOARD) {
     await this.destroyAssociatedDashboards(id, workspaceId);
   }

[Weiko]

LGTM!

[twenty-eng-sync]

Hey @bosiraphael! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[twenty-eng-sync]

Hey @bosiraphael! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!