Skip to content

fix: [#1079] adding max width to menu items and also the tooltip to show full text value#1088

Merged
charlesBochet merged 5 commits intotwentyhq:mainfrom
Daggerhub:fix/dropdown-line-clamp
Aug 7, 2023
Merged

fix: [#1079] adding max width to menu items and also the tooltip to show full text value#1088
charlesBochet merged 5 commits intotwentyhq:mainfrom
Daggerhub:fix/dropdown-line-clamp

Conversation

@Daggerhub
Copy link
Copy Markdown
Contributor

@Daggerhub Daggerhub commented Aug 5, 2023

Screenshot 2023-08-05 at 12 40 58 PM Screenshot 2023-08-05 at 12 41 09 PM

@ergomake
Copy link
Copy Markdown

ergomake bot commented Aug 5, 2023

Hi 👋

Here's a preview environment 🚀

https://front-twentyhq-twenty-1088.env.ergomake.link

Environment Summary 📑

Container Source URL
front Dockerfile https://front-twentyhq-twenty-1088.env.ergomake.link
server Dockerfile https://server-twentyhq-twenty-1088.env.ergomake.link
postgres Dockerfile [not exposed - internal service]

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

@charlesBochet
Copy link
Copy Markdown
Member

@Daggerhub we actually wanted to fix the dropdown width. I've done it in this PR: #1093

I believe you can rebase on main and work from there with OverflowingTextWithTooltip as you are already doing, should be straighforward!

@Daggerhub Daggerhub force-pushed the fix/dropdown-line-clamp branch from ed889d6 to 26fe462 Compare August 6, 2023 05:37
@Daggerhub
Copy link
Copy Markdown
Contributor Author

Hey @charlesBochet,
Have rebased my branch against main,
Please have a look.

Copy link
Copy Markdown
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comment, thanks!

@charlesBochet
Copy link
Copy Markdown
Member

@Daggerhub your tests are failing. I believe that you need to update the css selector in People.sortBy.stories
To run tests locally:
cd front && yarn storybook-dev # from here, you can go to localhost:6006 and see interactions tests, they should be failing on People.sortBy

in another terminal:
cd front && yarn coverage

@charlesBochet
Copy link
Copy Markdown
Member

You seem to have the same issue with Companies.sortBy!

@charlesBochet
Copy link
Copy Markdown
Member

Thank you! Merging!

@charlesBochet charlesBochet merged commit 0dcb93c into twentyhq:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants