Conversation
This reverts commit 17d32d6.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously introduced chat performance instrumentation (the commit referenced in the PR description), removing performance.mark(...) calls that were added across extension activation, prompt rendering, and the agent/tool-calling flow.
Changes:
- Removed
performance.markcalls from activation, prompt rendering, and the tool-calling loop. - Simplified a couple of affected code paths where temporary variables only existed to place post-return perf markers.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/extension/prompts/node/panel/customInstructions.tsx | Removes perf markers around custom-instructions prompt preparation. |
| src/extension/prompts/node/agent/agentPrompt.tsx | Removes perf markers around system prompt retrieval and global agent context creation; simplifies return flow. |
| src/extension/intents/node/toolCallingLoop.ts | Removes perf markers around loop execution, prompt building, and model fetch. |
| src/extension/extension/vscode/extension.ts | Removes perf markers during activation; returns activation API object directly. |
| src/extension/conversation/vscode-node/conversationFeature.ts | Removes perf markers while waiting for Copilot token availability. |
| src/extension/conversation/vscode-node/chatParticipants.ts | Removes perf markers around chat participant request handling. |
You can also share your feedback on Copilot code review. Take the survey.
mjbvz
approved these changes
Mar 19, 2026
pwang347
added a commit
that referenced
this pull request
Mar 24, 2026
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
* Revert "Revert "Add chat perf markers (#4456)" (#4508)" This reverts commit 094647e. * update * clean * PR * update * Clean * use sessions * fix * update * PR * Update src/util/common/test/performance.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/extension/intents/node/toolCallingLoop.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * PR --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 17d32d6.