Revert "Add chat perf markers (#4456)" (#4508)

This reverts commit 17d32d6.

Author: pwang347

src/extension/conversation/vscode-node/chatParticipants.ts

@@ -196,7 +196,6 @@ Learn more about [GitHub Copilot](https://docs.github.com/copilot/using-github-c
 
 	private getChatParticipantHandler(id: string, name: string, defaultIntentIdOrGetter: IntentOrGetter): vscode.ChatExtendedRequestHandler {
 		return async (request, context, stream, token): Promise<vscode.ChatResult> => {
-			performance.mark('code/chat/ext/willHandleParticipant');
 			// If we need to switch to the base model, this function will handle it
 			// Otherwise it just returns the same request passed into it
 			request = await this.switchToBaseModel(request, stream);
@@ -245,7 +244,6 @@ Learn more about [GitHub Copilot](https://docs.github.com/copilot/using-github-c
 				}
 			}
 
-			performance.mark('code/chat/ext/didHandleParticipant');
 			return result;
 		};
 	}

src/extension/conversation/vscode-node/conversationFeature.ts

@@ -94,15 +94,13 @@ export class ConversationFeature implements IExtensionContribution {
 			this.activated = true;
 			activationBlockerDeferred.complete();
 		} else {
-			performance.mark('code/chat/ext/willWaitForCopilotToken');
 			this.logService.info(`ConversationFeature: Waiting for copilot token to activate conversation feature`);
 		}
 
 		this._disposables.add(authenticationService.onDidAuthenticationChange(async () => {
 			const hasSession = !!authenticationService.copilotToken;
 			this.logService.info(`ConversationFeature: onDidAuthenticationChange has token: ${hasSession}`);
 			if (hasSession) {
-				performance.mark('code/chat/ext/didWaitForCopilotToken');
 				this.activated = true;
 			} else {
 				this.activated = false;

src/extension/extension/vscode/extension.ts

@@ -31,7 +31,6 @@ export interface IExtensionActivationConfiguration {
 }
 
 export async function baseActivate(configuration: IExtensionActivationConfiguration) {
-	performance.mark('code/chat/ext/willActivate');
 	const context = configuration.context;
 	if (context.extensionMode === ExtensionMode.Test && !configuration.forceActivation && !isScenarioAutomation) {
 		// FIXME Running in tests, don't activate the extension
@@ -66,22 +65,20 @@ export async function baseActivate(configuration: IExtensionActivationConfigurat
 
 		// Await intialization of exp service. This ensure cache is fresh.
 		// It will then auto refresh every 30 minutes after that.
-		performance.mark('code/chat/ext/willInitExperiments');
 		await expService.hasTreatments();
 
 		// THIS is awaited because some contributions can block activation
 		// via `IExtensionContribution#activationBlocker`
 		const contributions = instantiationService.createInstance(ContributionCollection, configuration.contributions);
 		context.subscriptions.push(contributions);
-		performance.mark('code/chat/ext/willWaitForActivationBlockers');
 		await contributions.waitForActivationBlockers();
 	});
 
 	if (ExtensionMode.Test === context.extensionMode && !isScenarioAutomation) {
 		return instantiationService; // The returned accessor is used in tests
 	}
 
-	const result = {
+	return {
 		getAPI(version: number) {
 			if (version > CopilotExtensionApi.version) {
 				throw new Error('Invalid Copilot Chat extension API version. Please upgrade Copilot Chat.');
@@ -90,8 +87,6 @@ export async function baseActivate(configuration: IExtensionActivationConfigurat
 			return instantiationService.createInstance(CopilotExtensionApi);
 		}
 	};
-	performance.mark('code/chat/ext/didActivate');
-	return result;
 }
 
 export function createInstantiationService(configuration: IExtensionActivationConfiguration): IInstantiationService {

src/extension/intents/node/toolCallingLoop.ts

@@ -731,9 +731,7 @@ export abstract class ToolCallingLoop<TOptions extends IToolCallingLoopOptions =
 				});
 
 				try {
-					performance.mark('code/chat/ext/willRunLoop');
 					const result = await this._runLoop(outputStream, token);
-					performance.mark('code/chat/ext/didRunLoop');
 					span.setAttributes({
 						[CopilotChatAttr.TURN_COUNT]: result.toolCallRounds.length,
 						[GenAiAttr.USAGE_INPUT_TOKENS]: totalInputTokens,
@@ -1040,9 +1038,7 @@ export abstract class ToolCallingLoop<TOptions extends IToolCallingLoopOptions =
 		let availableTools = await this.getAvailableTools(outputStream, token);
 		const context = this.createPromptContext(availableTools, outputStream);
 		const isContinuation = context.isContinuation || false;
-		performance.mark('code/chat/ext/willBuildPrompt');
 		const buildPromptResult: IBuildPromptResult = await this.buildPrompt2(context, outputStream, token);
-		performance.mark('code/chat/ext/didBuildPrompt');
 		this.throwIfCancelled(token);
 		this.turn.addReferences(buildPromptResult.references);
 		// Possible the tool call resulted in new tools getting added.
@@ -1146,7 +1142,6 @@ export abstract class ToolCallingLoop<TOptions extends IToolCallingLoopOptions =
 		const disableThinking = isContinuation && isAnthropicFamily(endpoint) && !ToolCallingLoop.messagesContainThinking(effectiveBuildPromptResult.messages);
 		let phase: string | undefined;
 		let compaction: OpenAIContextManagementResponse | undefined;
-		performance.mark('code/chat/ext/willFetch');
 		const fetchResult = await this.fetch({
 			messages: this.applyMessagePostProcessing(effectiveBuildPromptResult.messages, { stripOrphanedToolCalls: isGeminiFamily(endpoint) }),
 			turnId: this.turn.id,
@@ -1196,7 +1191,6 @@ export abstract class ToolCallingLoop<TOptions extends IToolCallingLoopOptions =
 		}, token).finally(() => {
 			this.stopHookUserInitiated = false;
 		});
-		performance.mark('code/chat/ext/didFetch');
 
 		const promptTokenDetails = await computePromptTokenDetails({
 			messages: effectiveBuildPromptResult.messages,

src/extension/prompts/node/agent/agentPrompt.tsx

@@ -97,9 +97,7 @@ export class AgentPrompt extends PromptElement<AgentPromptProps> {
 		if (!customizations) {
 			throw new Error('AgentPrompt requires customizations to be provided. Use PromptRegistry.resolveAllCustomizations() to resolve them.');
 		}
-		performance.mark('code/chat/ext/willGetSystemPrompt');
 		const instructions = await this.getSystemPrompt(customizations);
-		performance.mark('code/chat/ext/didGetSystemPrompt');
 		const CopilotIdentityRules = customizations.CopilotIdentityRulesClass;
 		const SafetyRules = customizations.SafetyRulesClass;
 
@@ -210,16 +208,13 @@ export class AgentPrompt extends PromptElement<AgentPromptProps> {
 	}
 
 	private async getOrCreateGlobalAgentContext(endpoint: IChatEndpoint): Promise<PromptPieceChild[]> {
-		performance.mark('code/chat/ext/willGetGlobalAgentContext');
 		const globalContext = await this.getOrCreateGlobalAgentContextContent(endpoint);
 		const isNewChat = this.props.promptContext.history?.length === 0;
 		// TODO:@bhavyau find a better way to extract session resource
 		const sessionResource = (this.props.promptContext.tools?.toolInvocationToken as any)?.sessionResource as string | undefined;
-		const result = globalContext ?
+		return globalContext ?
 			renderedMessageToTsxChildren(globalContext, !!this.props.enableCacheBreakpoints) :
 			<GlobalAgentContext enableCacheBreakpoints={!!this.props.enableCacheBreakpoints} availableTools={this.props.promptContext.tools?.availableTools} isNewChat={isNewChat} sessionResource={sessionResource} />;
-		performance.mark('code/chat/ext/didGetGlobalAgentContext');
-		return result;
 	}
 
 	private async getOrCreateGlobalAgentContextContent(endpoint: IChatEndpoint): Promise<Raw.ChatCompletionContentPart[] | undefined> {

src/extension/prompts/node/panel/customInstructions.tsx

@@ -64,7 +64,6 @@ export class CustomInstructions extends PromptElement<CustomInstructionsProps> {
 		super(props);
 	}
 	override async render(state: void, sizing: PromptSizing) {
-		performance.mark('code/chat/ext/willPrepareCustomInstructions');
 
 		const { includeCodeGenerationInstructions, includeTestGenerationInstructions, includeCodeFeedbackInstructions, includeCommitMessageGenerationInstructions, includePullRequestDescriptionGenerationInstructions, customIntroduction } = this.props;
 		const includeSystemMessageConflictWarning = this.props.includeSystemMessageConflictWarning ?? true;
@@ -129,9 +128,6 @@ export class CustomInstructions extends PromptElement<CustomInstructionsProps> {
 				chunks.push(chunk);
 			}
 		}
-
-		performance.mark('code/chat/ext/didPrepareCustomInstructions');
-
 		if (chunks.length === 0) {
 			return undefined;
 		}