signature attribute; small cleanup#1187
Merged
eddelbuettel merged 1 commit intoRcppCore:pr/1183from Oct 26, 2021
traversc:pr/1183
Merged
signature attribute; small cleanup#1187eddelbuettel merged 1 commit intoRcppCore:pr/1183from traversc:pr/1183
eddelbuettel merged 1 commit intoRcppCore:pr/1183from
traversc:pr/1183
Conversation
eddelbuettel
approved these changes
Oct 26, 2021
Member
|
Looks good. Let me wrap up what we have now in #1183 and throw it again at the rev.dep machine. Not expecting anything nefarious as unit tests rarely call |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes to pr/1183 based on @kevinushey 's comments.
Check
sig.empty()before callingsig.front()andsig.back()Change
-1tostd::string:nposfor stylistic reasons.Checks using github actions still pass: https://github.com/traversc/Rcpp/runs/4003616100?check_suite_focus=true