Skip to content

signature attribute; small cleanup#1187

Merged
eddelbuettel merged 1 commit intoRcppCore:pr/1183from
traversc:pr/1183
Oct 26, 2021
Merged

signature attribute; small cleanup#1187
eddelbuettel merged 1 commit intoRcppCore:pr/1183from
traversc:pr/1183

Conversation

@traversc
Copy link
Copy Markdown
Contributor

Two small changes to pr/1183 based on @kevinushey 's comments.

  1. Check sig.empty() before calling sig.front() and sig.back()

  2. Change -1 to std::string:npos for stylistic reasons.

Checks using github actions still pass: https://github.com/traversc/Rcpp/runs/4003616100?check_suite_focus=true

@eddelbuettel eddelbuettel merged commit 2f4280a into RcppCore:pr/1183 Oct 26, 2021
@eddelbuettel
Copy link
Copy Markdown
Member

Looks good. Let me wrap up what we have now in #1183 and throw it again at the rev.dep machine. Not expecting anything nefarious as unit tests rarely call compileAttributes() but it does not hurt to stick with the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants