Adding Rcpp signature attribute#1183
Adding Rcpp signature attribute#1183traversc wants to merge 0 commit intoRcppCore:masterfrom traversc:master
Conversation
|
Can you please enable the flag allowing the repo that you sent the PR to to commit in your clone too? I have to push a fix to permit tests to pass. |
|
Alternatively you can also cherry-pick commit 04d8b03 from the pr/1183 branch I just pushed (and where I permitted myself to rebase and squash you four commits with identical commit message into one). |
|
Added, sorry about that. |
|
(Took me a moment to realize I needed to force-push as I had rebased. Done now. And then I fat-fingered the close button by accident. Sorry.) Rev.dep run is progressing but it'll be some time tomorrow that we know more. |
|
Or maybe my force-push accidentally close this. Sorry. I'm just going to open a new one off the branch where I added the commit. |
|
#1184 is now in better shape after I arm-wrestled the codecov yaml file so that it no longer flags the PRs as failed on because coverage drops a little. |
Pull Request Template for Rcpp
Please explain the changes you want to apply to Rcpp, preferably in an issue ticket before you create a pull request. See the file Contributing and the other templates for details.
Checklist
R CMD checkstill passes all tests