Fix process of reference count during GC#103
Merged
mgedmin merged 3 commits intozopefoundation:masterfrom Sep 21, 2017
Merged
Conversation
call PyObject_GC_UnTrack() in tp_dealloc() see the following sites for details: * https://bugs.python.org/issue31095 * python/cpython#2974
mgedmin
approved these changes
Sep 19, 2017
Member
mgedmin
left a comment
mgedmin
left a comment
There was a problem hiding this comment.
Looks good to me, with one minor formatting comment.
| static int | ||
| lookup_clear(lookup *self) | ||
| { | ||
| { |
Member
There was a problem hiding this comment.
I would prefer not to see unnecessary trailing whitespace being added to an unrelated function.
Contributor
Author
There was a problem hiding this comment.
I appreciate you removing it.
Member
There was a problem hiding this comment.
@y-fujisaki2 I believe @mgedmin was requesting that you update the PR to avoid this problem. I am making the same request.
Thank you for follows. I misread it for carriage return.
jamadden
approved these changes
Sep 21, 2017
Member
jamadden
left a comment
jamadden
left a comment
There was a problem hiding this comment.
LGTM. I don't think this is something we have to have a signed contributor agreement for, so we should be good to merge.
Member
|
Thank you! |
Member
|
I've released zope.interface 4.4.3 to PyPI with this fix. |
Contributor
Author
|
Thank you so much for follows! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
call PyObject_GC_UnTrack() in tp_dealloc()
see the following sites for details:
Fixes #100.