fix(compat): update patch for typescript@5.5.0-beta#6248
Merged
Conversation
merceyz
force-pushed
the
merceyz/fix/typescript-55-beta
branch
from
3d7ae22 to
d58ffb4
Compare
1 task
Contributor
|
Fixes #6250 |
Contributor
|
Hello @merceyz I tried in the past to apply similar patches for new versions of TS, but I don't exactly know what are the steps to go from microsoft/TypeScript#35206 to the fixes in the yarn repo. |
|
would love to use 5.5-beta as well :) |
Member
Author
|
@Ayc0 I create a new branch based on the upstream release branch and cherry-pick the commits from the last time I updated the patch and fix any conflicts that may show up. |
3 tasks
arcanis
pushed a commit
that referenced
this pull request
May 2, 2024
**What's the problem this PR addresses?** The SDK changes in #6248 broke support for older TypeScript versions. I tested it on `5.4.1-rc` (master) and it was fine but it crashes on 5.2.0-beta (https://github.com/yarnpkg/berry/blob/4308dca8091438e8f88682e59ef5ba5bc72241ca/package.json#L26) **How did you fix it?** Check the TypeScript version and only apply the patch if needed. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
added a commit
that referenced
this pull request
May 2, 2024
**What's the problem this PR addresses?** The PnP compatibility patch for TypeScript doesn't apply to `typescript@5.5.0-beta`. Ref microsoft/TypeScript#35206 **How did you fix it?** Rebased it. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
added a commit
that referenced
this pull request
May 2, 2024
**What's the problem this PR addresses?** The SDK changes in #6248 broke support for older TypeScript versions. I tested it on `5.4.1-rc` (master) and it was fine but it crashes on 5.2.0-beta (https://github.com/yarnpkg/berry/blob/4308dca8091438e8f88682e59ef5ba5bc72241ca/package.json#L26) **How did you fix it?** Check the TypeScript version and only apply the patch if needed. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Contributor
|
I feel there is the same issue with 5.6-rc this time 🤔 |
Member
|
There's a draft PR: #6461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The PnP compatibility patch for TypeScript doesn't apply to
typescript@5.5.0-beta.Ref microsoft/TypeScript#35206
How did you fix it?
Rebased it.
Checklist