Skip to content

Feat/harmonize chips cell fields#724

Merged
charlesBochet merged 3 commits intomainfrom
feat/harmonize-chips-cell-fields
Jul 18, 2023
Merged

Feat/harmonize chips cell fields#724
charlesBochet merged 3 commits intomainfrom
feat/harmonize-chips-cell-fields

Conversation

@lucasbordeau
Copy link
Copy Markdown
Contributor

Closes #664 #701 #687

  • Fixed bug when clicking on a chip, it does not open the cell anymore.
  • Fixed company show page fields
  • Added a clickable props on EntityChip (refactored)
  • Added recoil hotkeys states for fields


export function CompanyChip({ id, name, picture, clickable }: OwnProps) {
return (
<ContainerComponent data-testid="company-chip" to={`/companies/${id}`}>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will likely break tests?


width: 100%;
${(props) => {
console.log(props.isDisplayModeContentEmpty);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log

@charlesBochet charlesBochet merged commit 5b21657 into main Jul 18, 2023
@charlesBochet charlesBochet deleted the feat/harmonize-chips-cell-fields branch July 18, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harmonize clickable field / inputs / cells / chips

2 participants