Skip to content

Fix queue setup#3075

Merged
charlesBochet merged 1 commit intomainfrom
c--fix-bullmq-setup
Dec 19, 2023
Merged

Fix queue setup#3075
charlesBochet merged 1 commit intomainfrom
c--fix-bullmq-setup

Conversation

@Weiko
Copy link
Copy Markdown
Member

@Weiko Weiko commented Dec 19, 2023

Context

  • Fixed bull-mq setup: It needs the option parameter for Queues/Workers instantiations, I've added the missing one
  • Fixed pg-boss missing singletonKey, it is used a bit differently with pg-boss so I had to adapt the driver accordingly to have an aligned API
  • Fixed a few typeorm entities that were not aligned with the DB (and so the previous migrations).
    See here that now it matches with the DB when I run a generate after a db:reset
Screenshot 2023-12-19 at 16 46 36

Tested

locally with this redis image docker run -d --name redis-stack -p 6379:6379 -p 8001:8001 redis/redis-stack:latest
Screenshot 2023-12-19 at 16 45 03

@Weiko Weiko changed the title Fix bull-mq setup Fix queue setup Dec 19, 2023
Copy link
Copy Markdown
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@charlesBochet charlesBochet merged commit 4637a92 into main Dec 19, 2023
@charlesBochet charlesBochet deleted the c--fix-bullmq-setup branch December 19, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants