Upload image for use in blocknote editor#3044
Merged
lucasbordeau merged 4 commits intotwentyhq:mainfrom Dec 20, 2023
Merged
Conversation
- fix local-storage not in gitignore
charlesBochet
previously approved these changes
Dec 18, 2023
Member
charlesBochet
left a comment
There was a problem hiding this comment.
LGTM with minor comment @brendanlaschke, thanks as always!
packages/twenty-front/src/modules/activities/components/ActivityBodyEditor.tsx
Outdated
Show resolved
Hide resolved
Member
|
@brendanlaschke I've found a bug actually. If the image is the first child of the body: I think it's because it has no "content" section. We should update this logic: I also think we should extract it to an util |
Merged
add tests for body parsing notes and tasks
Contributor
Author
|
done - also for the similar preview in the notes tab ... |
lucasbordeau
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Completes the work of #1964 to also upload images.
closes #1878
Fixed also local-storage not in gitignore