fix: empty state should not appear during table loading#3040
Merged
charlesBochet merged 4 commits intotwentyhq:mainfrom Dec 20, 2023
Merged
fix: empty state should not appear during table loading#3040charlesBochet merged 4 commits intotwentyhq:mainfrom
charlesBochet merged 4 commits intotwentyhq:mainfrom
Conversation
Member
|
@a-kud Thank you :) Then, in RecordTableBodyEffect you should be able to compute it based on |
51dbcd6 to
26d99f8
Compare
26d99f8 to
62e78ac
Compare
62e78ac to
fbd6684
Compare
charlesBochet
approved these changes
Dec 20, 2023
Member
charlesBochet
left a comment
There was a problem hiding this comment.
Thank you! Works well, I have also removed unused code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2969
Display an empty table directly instead of showing the empty state.