2503-feat(front): hover icons added; commandmenu open added#2622
Merged
charlesBochet merged 3 commits intotwentyhq:mainfrom Dec 1, 2023
Merged
2503-feat(front): hover icons added; commandmenu open added#2622charlesBochet merged 3 commits intotwentyhq:mainfrom
charlesBochet merged 3 commits intotwentyhq:mainfrom
Conversation
Member
|
@Kanav-Arora Thank you, I've left comments! |
Contributor
Author
|
Hi @charlesBochet |
charlesBochet
approved these changes
Dec 1, 2023
Member
charlesBochet
left a comment
charlesBochet
left a comment
There was a problem hiding this comment.
Thank you @Kanav-Arora!
charlesBochet
approved these changes
Dec 1, 2023
Member
charlesBochet
left a comment
charlesBochet
left a comment
There was a problem hiding this comment.
@Kanav-Arora Thank you! I've taken care of conflicts!
Also, we have discussed with @Bonapara and in the end, adding a LightIconButtonGroup does not make sense and we want to stick with two Icons and not offer a group for light icon buttons as part of Twenty UI library
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2503
The new adding of card seems to be undeveloped as
+ Newbutton is not working.