Skip to content

feat: activate and disable objects#2194

Merged
charlesBochet merged 1 commit intomainfrom
feat/activate-and-disable-objects
Oct 24, 2023
Merged

feat: activate and disable objects#2194
charlesBochet merged 1 commit intomainfrom
feat/activate-and-disable-objects

Conversation

@thaisguigon
Copy link
Copy Markdown
Contributor

Closes #2144, Closes #2148, Closes #2154

@thaisguigon thaisguigon marked this pull request as ready for review October 23, 2023 11:10
Copy link
Copy Markdown
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging with minor comments

import { useUpdateOneMetadataObject } from './useUpdateOneMetadataObject';

export const useObjectMetadata = () => {
const activeMetadataObjects = useRecoilValue(activeMetadataObjectsSelector);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these still in use? if not we should remove the selectors files

}
dropdownHotkeyScope={{
scope: scopeKey + '-settings-object-disabled-menu-dropdown',
scope: dropdownScopeId,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure it's a good practice to mix scopeIds and hotkeyScopeIds, it looks to be fine from a behavior perspective but I fear developers will confuse both

@charlesBochet charlesBochet merged commit 26e8cd7 into main Oct 24, 2023
@charlesBochet charlesBochet deleted the feat/activate-and-disable-objects branch October 24, 2023 06:07
@charlesBochet charlesBochet mentioned this pull request Nov 30, 2023
FelixMalfait added a commit that referenced this pull request Feb 2, 2026
## Summary
- Add `repository_dispatch` trigger to `claude.yml` so `@claude`
mentions in `twentyhq/core-team-issues` get forwarded here
- New `claude-cross-repo` job: builds a prompt from the dispatch
payload, runs Claude Code against the twenty codebase, and posts a link
back to the source issue
- Switch both jobs to use `claude_code_oauth_token` instead of
`anthropic_api_key`

A companion workflow (`claude-dispatch.yml`) was pushed to
`twentyhq/core-team-issues` to send the dispatches.

## Test plan
- [x] Dispatch workflow in core-team-issues triggers successfully
(tested via issue #2194)
- [ ] After merge, verify `repository_dispatch` triggers the
`claude-cross-repo` job in twenty
- [ ] Verify Claude responds and posts a link back to the source issue

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Object Edit - Disable object Object Detail - Add "About" section dropdown Object Settings - Activate a disabled object

2 participants