Skip to content

fix: value changes every render#2115

Merged
charlesBochet merged 3 commits intotwentyhq:mainfrom
rustam-mukhametshin:patch-1
Oct 21, 2023
Merged

fix: value changes every render#2115
charlesBochet merged 3 commits intotwentyhq:mainfrom
rustam-mukhametshin:patch-1

Conversation

@rustam-mukhametshin
Copy link
Copy Markdown
Contributor

The object passed as the value prop to the context provider changes every render.

@sweep-ai-deprecated
Copy link
Copy Markdown
Contributor

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@charlesBochet
Copy link
Copy Markdown
Member

@rustam-mukhametshin, thank you! Could you fix the linter issue?
you can run: yarn lint from front folder

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 21, 2023

CLA assistant check
All committers have signed the CLA.

@charlesBochet charlesBochet merged commit 6d8effa into twentyhq:main Oct 21, 2023
khakimov pushed a commit to khakimov/twenty that referenced this pull request Oct 21, 2023
* fix: value changes every render

* Fix lint

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
@charlesBochet charlesBochet mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants