Implement page layout override

[Weiko]

No description provided.

[cubic-dev-ai]

No issues found across 41 files

[FelixMalfait]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:18254

This environment will automatically shut down after 5 hours.

[greptile-apps]

Greptile Summary

This PR introduces a page-layout override system that allows workspace custom applications to override specific properties (title, position, icon, conditionalDisplay) of standard-application-owned page layout tabs and widgets without mutating the originals. Changes span a DB migration (adding a nullable overrides JSONB column to both tables), a new OverridableEntity base class, three core utility functions (isCallerOverridingEntity, sanitizeOverridableEntityInput, resolveOverridableEntityProperty), and updated entity/DTO/service wiring throughout the page layout stack.

Key changes:

• New migration adds overrides jsonb column to pageLayoutTab and pageLayoutWidget tables
• OverridableEntity<T> abstract base class keeps override data in a JSONB column typed to per-entity override shapes
• isCallerOverridingEntity gates the override path: overrides are only applied when the caller is the workspace-custom app and the entity was created by a different (standard) application
• sanitizeOverridableEntityInput separates overridable properties from the direct-update payload and manages the overrides JSONB object
• Properties marked isOverridable: true in ALL_ENTITY_PROPERTIES_CONFIGURATION_BY_METADATA_NAME: tab (title, position, icon) and widget (title, position, conditionalDisplay)

Issues found:

• The "reset override" branch in sanitizeOverridableEntityInput uses strict reference equality (===) which is correct for primitive fields but silently fails for widget object-typed overridable fields (position, conditionalDisplay), meaning stale overrides for those fields can never be cleared
• sanitizeOverridableEntityInput mutates the caller-supplied updatedEditableProperties object in-place while also returning it — the mutation could surprise callers holding a separate reference
• isCallerOverridingEntity uses an implicit arrow-function return, which conflicts with the project's style convention
• No unit tests for the three new override utility functions despite their non-trivial branching

Confidence Score: 2/5

• The PR is architecturally sound but has a correctness bug in override-clearing logic for object-typed widget properties that will cause silent data staleness, plus a surprising input mutation pattern and missing test coverage.
• The PR is safe to merge functionally for primitive-typed overrides (all tab properties: title, position, icon). However, there is a correctness bug for widget object-typed properties (position and conditionalDisplay): strict reference equality (===) cannot clear stale overrides for object fields, meaning once an override is set for these properties, it can never be removed even when reset to the base value. Additionally, sanitizeOverridableEntityInput mutates its input parameter in-place, which violates the principle of least surprise. The missing unit tests for three core override utility functions add maintenance risk. Style violations are minor in comparison.
• packages/twenty-server/src/engine/metadata-modules/utils/sanitize-overridable-entity-input.util.ts requires the most attention due to the object equality bug for widget overridable properties and the input mutation pattern.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Client calls updatePageLayoutTab / updatePageLayoutWidget"] --> B["Fetch workspaceCustomFlatApplication"]
    B --> C["Fetch existing FlatEntity from cache"]
    C --> D["extractAndSanitizeObjectStringFields\n(get editable properties)"]
    D --> E["isCallerOverridingEntity()\ncaller == workspaceCustomApp?\nentity belongs to standard app?"]
    E -->|"false (own entity)"| F["sanitizeOverridableEntityInput\nshouldOverride=false\npreserve existing overrides"]
    E -->|"true (standard entity)"| G["sanitizeOverridableEntityInput\nshouldOverride=true"]
    G --> H{"For each overridable property\nin updatedEditableProperties"}
    H -->|"value == base entity value"| I["Remove property from overrides\n(clear stale override)"]
    H -->|"value != base entity value"| J["Add/update property in overrides\nRemove from direct update payload"]
    H -->|"property not in update"| K["Keep existing override value"]
    I & J & K --> L["Merge: overrides=computed,\nupdatedEditableProperties=sanitized"]
    F --> L
    L --> M["validateBuildAndRunWorkspaceMigration"]
    M --> N["Persist to DB: entity updated,\noverrides JSONB column updated"]

Loading

_{Last reviewed commit: 22d420a}

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[Weiko]

@greptileai trigger

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[thomtrp]

LGTM

[thomtrp]

nit: isDefined for consistency?

[twenty-eng-sync]

Hey @Weiko! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[twenty-eng-sync]

Hey @Weiko! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!