chore(front): remove vite-plugin-checker background TS/ESLint checks#18437
chore(front): remove vite-plugin-checker background TS/ESLint checks#18437charlesBochet merged 1 commit intomainfrom
Conversation
Background TypeScript and ESLint checks via vite-plugin-checker are no longer needed. Our dev experience now relies on independent linters and type-checkers (npx nx lint and npx nx typecheck) that run separately from the Vite build process, making the in-process checker redundant and an unnecessary memory overhead. Made-with: Cursor
Greptile SummaryThis PR removes Key changes:
This is a clean removal with no runtime impact on the application—all type checking and linting is preserved via independent Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before this PR"]
B_Dev["vite dev / vite build"]
B_Checker["vite-plugin-checker<br/>(TS + ESLint in-process)"]
B_Env["VITE_DISABLE_TYPESCRIPT_CHECKER=true<br/>(escape hatch)"]
B_Dev --> B_Checker
B_Env -. disables .-> B_Checker
end
subgraph After["After this PR"]
A_Dev["vite dev / vite build<br/>(no checker plugin)"]
A_TS["npx nx typecheck twenty-front<br/>(separate process)"]
A_Lint["npx nx lint:diff-with-main twenty-front<br/>(separate process)"]
A_Dev
A_TS
A_Lint
end
Before -->|"PR removes checker,<br/>env var, escape hatch"| After
Last reviewed commit: 3d8697c |
There was a problem hiding this comment.
Pull request overview
Removes vite-plugin-checker and the associated Vite env-var toggles, shifting type-checking and linting to separate Nx tasks to improve dev/build performance and reduce memory overhead.
Changes:
- Removed
vite-plugin-checkerusage frompackages/twenty-front/vite.config.tsand droppedVITE_DISABLE_TYPESCRIPT_CHECKERsupport. - Cleaned up related build/storybook commands and removed
vite-plugin-checkerfromdevDependencies. - Removed now-obsolete troubleshooting guidance across the main docs and translations.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/twenty-front/vite.config.ts | Removes checker plugin wiring and related env-var logic. |
| packages/twenty-front/package.json | Updates build scripts and drops vite-plugin-checker dependency. |
| packages/twenty-front/.env.example | Removes the deprecated env-var example. |
| packages/twenty-docs/developers/self-host/capabilities/troubleshooting.mdx | Removes outdated advice for disabling Vite background checks. |
| packages/twenty-docs/l/ar/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (AR). |
| packages/twenty-docs/l/cs/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (CS). |
| packages/twenty-docs/l/de/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (DE). |
| packages/twenty-docs/l/es/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (ES). |
| packages/twenty-docs/l/fr/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (FR). |
| packages/twenty-docs/l/it/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (IT). |
| packages/twenty-docs/l/ja/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (JA). |
| packages/twenty-docs/l/ko/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (KO). |
| packages/twenty-docs/l/pt/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (PT). |
| packages/twenty-docs/l/ro/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (RO). |
| packages/twenty-docs/l/ru/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (RU). |
| packages/twenty-docs/l/tr/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (TR). |
| packages/twenty-docs/l/zh/developers/self-host/capabilities/troubleshooting.mdx | Same troubleshooting cleanup (ZH). |
| nx.json | Removes deprecated env-var from storybook build command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Run only the services you need, instead of `npx nx start`. Ad esempio, se lavori sul server, esegui solo `npx nx worker twenty-server` | ||
|
|
||
| **If it does not work:** |
There was a problem hiding this comment.
This Italian localized troubleshooting page still contains English sentences/headers (e.g., “Run only the services you need” / “If it does not work”). Since this section is user-facing documentation, it should be fully translated to Italian (or replaced with the localized equivalent) for consistency with the rest of the file.
Summary
Removes
vite-plugin-checkerand all references toVITE_DISABLE_TYPESCRIPT_CHECKER/VITE_DISABLE_ESLINT_CHECKER.These background checks are no longer needed because our dev experience now relies on independent linters and type-checkers:
npx nx lint:diff-with-main twenty-frontfor ESLintnpx nx typecheck twenty-frontfor TypeScriptRunning these as separate processes (rather than inside Vite) is faster, gives cleaner output, and avoids the significant memory overhead that
vite-plugin-checkerintroduces duringvite devandvite build. The old env vars to disable them are removed fromvite.config.ts,package.jsonscripts,nx.json,.env.example, and all translated docs.