Fix E2E tests broken by redesigned navigation menu

[FelixMalfait]

Summary

• Settings selector: The Settings navigation item is now rendered as a <button> (via NavigationDrawerItem with onClick) instead of an <a> link (with to). Updated leftMenu.ts POM and create-kanban-view.spec.ts to use getByRole('button', { name: 'Settings' }).
• create-record URL field: The Linkedin field interaction was missing an initial label click to trigger the hover portal rendering. Added recordFieldList.getByText('Linkedin').first().click() before the value click, matching the pattern used by the working Emails field.

Test plan

• E2E signup_invite_email.spec.ts passes (uses leftMenu.goToSettings())
• E2E create-kanban-view.spec.ts passes (uses Settings click directly)
• E2E create-record.spec.ts passes (Linkedin URL field interaction)
• Existing passing E2E tests remain green

Made with Cursor

[cubic-dev-ai]

No issues found across 3 files

[greptile-apps]

Greptile Summary

Updated E2E test selectors to match the redesigned navigation menu where Settings changed from an anchor link to a button element. The PR also fixed the LinkedIn URL field interaction by adding an initial label click to trigger the hover portal rendering, matching the existing pattern used for the Emails field.

• Changed Settings selector from getByRole('link') to getByRole('button') in POM and test files
• Added missing label click for LinkedIn field interaction in create-record.spec.ts
• All changes are minimal, focused test fixes with no logic or security concerns

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The changes are straightforward test selector updates that correctly reflect UI changes. The Settings element role change from link to button is consistently applied across all files, and the LinkedIn field fix follows the established pattern used for the Emails field.
• No files require special attention

Important Files Changed

Filename	Overview
packages/twenty-e2e-testing/lib/pom/leftMenu.ts	Updated Settings tab selector from link to button role, correctly reflecting the redesigned navigation menu
packages/twenty-e2e-testing/tests/create-kanban-view.spec.ts	Updated Settings selector to use button role instead of link, consistent with POM changes
packages/twenty-e2e-testing/tests/create-record.spec.ts	Added initial label click for LinkedIn field to trigger hover portal rendering, matching the Emails field pattern

_{Last reviewed commit: 3c88708}

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[sentry]

Bug: The .click() call on line 119 is missing the await keyword. This is inconsistent with other asynchronous calls in the test file, creating potential flakiness.
_{Severity: MEDIUM}

Suggested Fix

Add the await keyword before the .click() call on line 119 to ensure the asynchronous operation completes before the test proceeds. The line should be await recordFieldList.getByText('Work Preference').first().click({force: true});.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/twenty-e2e-testing/tests/create-record.spec.ts#L96

Potential issue: In the E2E test, a `.click()` call on line 119 is not awaited. Since
`click()` is an asynchronous Playwright function, failing to `await` it means the test
execution will not wait for the action to complete. This introduces a potential race
condition and can lead to flaky tests. While the subsequent operation is independent,
this violates the established pattern in the file and Playwright best practices. Any
errors thrown by the click action would also not be properly handled, potentially
masking issues.

[twenty-eng-sync]

Hey @FelixMalfait! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!