Fix dropdown scroll by restoring scroll container nesting order

[ehconitin]

No description provided.

[cubic-dev-ai]

No issues found across 1 file

[twenty-eng-sync]

Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[github-actions]

Thanks @ehconitin for your contribution!
This marks your 324th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

[greptile-apps]

Greptile Summary

This PR fixes dropdown scroll behavior by reversing the nesting order of the scroll container and padding container. Previously, the padding was applied outside the scrollable area, which caused scroll calculation issues. Now the scrollable container is outermost, with padding applied inside.

• Swapped StyledScrollableContainer and StyledExternalContainer nesting in scrollable mode
• Moved role="listbox" attribute from outer to inner container (may affect accessibility)
• Padding now scrolls with content instead of being fixed outside scroll area

Confidence Score: 4/5

• This PR is safe to merge with one accessibility consideration to verify
• The change is a simple DOM nesting swap that fixes scroll behavior. However, moving the ARIA role="listbox" attribute from the scrollable container to an inner element may affect screen readers and should be tested for accessibility compliance.
• Verify DropdownMenuItemsContainer.tsx works correctly with screen readers after the role="listbox" attribute change

Important Files Changed

Filename	Overview
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuItemsContainer.tsx	Swapped nesting order of scroll and padding containers to fix scroll behavior; accessibility attribute role="listbox" moved to inner container

_{Last reviewed commit: 8e91c87}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

moving role="listbox" inside the scrollable container may affect accessibility tools that expect the scrollable element itself to have this ARIA role

Suggested change

	<StyledExternalContainer role="listbox">
	<StyledScrollableContainer
	role="listbox"