Allow video, audio and iFrame in front components#18200
Merged
charlesBochet merged 6 commits intomainfrom Feb 24, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR enables video, audio, and iframe elements in the front component renderer and fixes a bug with CSS custom properties (variables starting with Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 88cbfa3 |
Contributor
Author
prastoin
approved these changes
Feb 24, 2026
packages/twenty-sdk/src/front-component-renderer/host/utils/createHtmlHostWrapper.ts
Outdated
Show resolved
Hide resolved
| loop: { type: Boolean }, | ||
| muted: { type: Boolean }, | ||
| preload: { type: String }, | ||
| crossOrigin: { type: String }, |
Contributor
There was a problem hiding this comment.
Challenge: Do we really want to ? All files should be on twenty files no ?
packages/twenty-sdk/src/front-component-renderer/remote/generated/remote-elements.ts
Show resolved
Hide resolved
packages/twenty-sdk/src/front-component-renderer/remote/generated/remote-elements.ts
Show resolved
Hide resolved
packages/twenty-sdk/src/sdk/front-component-api/constants/AllowedHtmlElements.ts
Outdated
Show resolved
Hide resolved
packages/twenty-sdk/src/front-component-renderer/host/generated/host-component-registry.ts
Show resolved
Hide resolved
charlesBochet
approved these changes
Feb 24, 2026
packages/twenty-sdk/src/front-component-renderer/host/utils/createHtmlHostWrapper.ts
Show resolved
Hide resolved
packages/twenty-sdk/src/sdk/front-component-api/constants/AllowedHtmlElements.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow video, audio and iFrame in front components
--