Skip to content

Change runner from depot-ubuntu-24.04 to ubuntu-latest#18182

Merged
FelixMalfait merged 1 commit intomainfrom
FelixMalfait-patch-1
Feb 24, 2026
Merged

Change runner from depot-ubuntu-24.04 to ubuntu-latest#18182
FelixMalfait merged 1 commit intomainfrom
FelixMalfait-patch-1

Conversation

@FelixMalfait
Copy link
Copy Markdown
Member

No description provided.

@FelixMalfait FelixMalfait merged commit 458a61e into main Feb 24, 2026
17 of 21 checks passed
@FelixMalfait FelixMalfait deleted the FelixMalfait-patch-1 branch February 24, 2026 09:17
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

preview-environment:
timeout-minutes: 310
runs-on: depot-ubuntu-24.04
runs-on: ubuntu-latest
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflow will fail because it switches to the ubuntu-latest runner but does not install yq, a required dependency that is not pre-installed on that image.
Severity: CRITICAL

Suggested Fix

Add a step to the preview-env-keepalive.yaml workflow to install the yq dependency before it is used. For example, this can be done by adding a run step to install it via a package manager.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/preview-env-keepalive.yaml#L14

Potential issue: The `preview-env-keepalive.yaml` workflow is being updated to run on
`ubuntu-latest`. However, the workflow script depends on the `yq` command-line tool,
which is not pre-installed on the standard `ubuntu-latest` runner image. The workflow
does not include a step to install this dependency. As a result, when the workflow
executes a command like `yq eval`, it will fail with a "command not found" error. This
will cause the entire workflow to crash at runtime, preventing the creation of preview
environments.

Did we get this right? 👍 / 👎 to inform future reviews.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 24, 2026

Greptile Summary

Changed the GitHub Actions runner from depot-ubuntu-24.04 to ubuntu-latest for the preview environment keep-alive workflow.

  • Creates inconsistency across the repository's CI/CD setup - 41 other workflow jobs still use depot runners (depot-ubuntu-24.04 or depot-ubuntu-24.04-8)
  • Recent git history shows the project recently restored depot runners in PR Restore depot #18179, making this change potentially contradictory
  • May impact workflow performance or behavior differences between depot and standard GitHub-hosted runners

Confidence Score: 3/5

  • This PR is safe to merge but creates inconsistency in the CI/CD infrastructure
  • The change is minimal and won't break functionality, but it creates inconsistency with 41 other workflow jobs using depot runners. The motivation for this specific change is unclear given that PR Restore depot #18179 recently restored depot runners across the codebase.
  • Verify that standard GitHub runners provide adequate performance for this 5-hour keep-alive workflow

Important Files Changed

Filename Overview
.github/workflows/preview-env-keepalive.yaml Changed runner from depot-ubuntu-24.04 to ubuntu-latest, creating inconsistency with 41 other workflow jobs still using depot runners

Last reviewed commit: 094c388

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

preview-environment:
timeout-minutes: 310
runs-on: depot-ubuntu-24.04
runs-on: ubuntu-latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent with other workflows - 32 jobs use depot-ubuntu-24.04 and 9 use depot-ubuntu-24.04-8; only this workflow now uses ubuntu-latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant