Change runner from depot-ubuntu-24.04 to ubuntu-latest#18182
Change runner from depot-ubuntu-24.04 to ubuntu-latest#18182FelixMalfait merged 1 commit intomainfrom
Conversation
| preview-environment: | ||
| timeout-minutes: 310 | ||
| runs-on: depot-ubuntu-24.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Bug: The workflow will fail because it switches to the ubuntu-latest runner but does not install yq, a required dependency that is not pre-installed on that image.
Severity: CRITICAL
Suggested Fix
Add a step to the preview-env-keepalive.yaml workflow to install the yq dependency before it is used. For example, this can be done by adding a run step to install it via a package manager.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/preview-env-keepalive.yaml#L14
Potential issue: The `preview-env-keepalive.yaml` workflow is being updated to run on
`ubuntu-latest`. However, the workflow script depends on the `yq` command-line tool,
which is not pre-installed on the standard `ubuntu-latest` runner image. The workflow
does not include a step to install this dependency. As a result, when the workflow
executes a command like `yq eval`, it will fail with a "command not found" error. This
will cause the entire workflow to crash at runtime, preventing the creation of preview
environments.
Did we get this right? 👍 / 👎 to inform future reviews.
Greptile SummaryChanged the GitHub Actions runner from
Confidence Score: 3/5
Important Files Changed
Last reviewed commit: 094c388 |
| preview-environment: | ||
| timeout-minutes: 310 | ||
| runs-on: depot-ubuntu-24.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
inconsistent with other workflows - 32 jobs use depot-ubuntu-24.04 and 9 use depot-ubuntu-24.04-8; only this workflow now uses ubuntu-latest
No description provided.