Merged
Conversation
- Migrate 22 client-config states from createState to createStateV2 - Update ~55 consumer files to use V2 hooks (useRecoilValueV2, useRecoilStateV2, useSetRecoilStateV2) - Convert useRecoilCallback to useCallback + jotaiStore.get for captchaState in useRequestFreshCaptchaToken - Simplify clearSession in useAuth by removing snapshot read/restore for client-config states (now Jotai, unaffected by goToRecoilSnapshot) - Update test files to use jotaiStore.set for migrated states Co-authored-by: Cursor <cursoragent@cursor.com>
…otai V2 Migrate 3 states (objectMetadataItemsState, lastFieldMetadataItemUpdateState, shouldAppBeLoadingState) and 12 selectors/family selectors to Jotai V2. Extends the V2 abstraction layer: - Add SelectorV2 and FamilySelectorV2 support to SelectorGetterV2 type - Extend buildGetHelper to handle SelectorV2 and FamilySelectorV2 Update ~90 consumer files across the codebase to use V2 hooks (useRecoilValueV2, useFamilySelectorValueV2, useSetRecoilStateV2) and jotaiStore.get/set for callbacks. Bridge remaining Recoil selectors that depend on migrated states via jotaiStore.get. Co-authored-by: Cursor <cursoragent@cursor.com>
- Migrate objectPermissionsFamilySelector to createFamilySelectorV2 (all deps are Jotai V2; removes stale Recoil bridge) - Update useShouldActionBeRegisteredParams to use jotaiStore.get instead of useRecoilCallback for objectPermissionsFamilySelector - Migrate recordStoreIdentifiersFamilySelector to createFamilySelectorV2 using recordStoreFamilyStateV2 (kept in sync); update consumer useCommandMenuContextChips to use useFamilySelectorValueV2 - Fix useBrowsingContext to use store from useStore() instead of global jotaiStore for objectMetadataItemsState - Add TODO comment to visibleRecordFieldsComponentSelector acknowledging temporary jotaiStore bridge (currentRecordFieldsComponentState still Recoil) - Simplify createJotaiCookieStorage setItem by computing valueToStore first and removing the isNullish variable - Revert unrelated SDK improvements commit (app-typecheck.ts and other SDK files not linked to this Jotai migration PR) Co-authored-by: Cursor <cursoragent@cursor.com>
Extract content into an inner component so hooks are only called when
objectMetadataId is defined, preventing the render-time throw
("Object metadata id is missing from current view") that fires when the
filter dropdown renders before core views have been fetched.
Co-authored-by: Cursor <cursoragent@cursor.com>
…l load" This reverts commit 0df4821.
- Resolve conflict in useOpenRecordInCommandMenu.ts (keep jotaiStore + add CommandMenuPages) - Resolve conflict in useFrontComponentExecutionContext.ts (keep useRecoilValueV2, add new imports from main) - Resolve conflict in MetadataProviderEffect.tsx (adapt split setCoreViews logic to Jotai V2 store.set/get) - Accept deletion of SettingsAIRouterSettings.tsx from main Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Too many files changed for review. ( |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
Hey @charlesBochet! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.