Skip to content

Some fixes#17904

Merged
ijreilly merged 2 commits intomainfrom
fix--various-fixes-2
Feb 13, 2026
Merged

Some fixes#17904
ijreilly merged 2 commits intomainfrom
fix--various-fixes-2

Conversation

@ijreilly
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR contains two bug fixes:

  • Frontend: Prevents crashes by filtering out undefined field metadata items before generating GraphQL fields in useRecordsFieldVisibleGqlFields
  • Backend: Improves error handling in getDomainNameByEmail by replacing generic errors with structured UserInputError exceptions that include user-friendly messages with i18n support using the msg macro from @lingui/core

The changes follow the codebase patterns, use existing utility functions (isDefined, isNonEmptyString), and include comprehensive test coverage.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Both fixes are straightforward defensive programming improvements with comprehensive test coverage. The frontend change adds proper undefined filtering using the standard isDefined utility, and the backend change upgrades error handling to use structured exceptions with i18n support following established patterns in the codebase.
  • No files require special attention

Important Files Changed

Filename Overview
packages/twenty-front/src/modules/object-record/record-field/hooks/useRecordsFieldVisibleGqlFields.ts Added filter(isDefined) to prevent undefined field metadata items from being passed to generateDepthRecordGqlFieldsFromFields
packages/twenty-server/src/utils/get-domain-name-by-email.ts Improved error handling by replacing generic Error with UserInputError and adding user-friendly messages with i18n support
packages/twenty-server/src/utils/test/get-domain-name-by-email.spec.ts Updated tests to validate UserInputError with proper error codes and user-friendly messages instead of generic Error

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijreilly ijreilly enabled auto-merge February 12, 2026 17:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 12, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:28889

This environment will automatically shut down when the PR is closed or after 5 hours.

@ijreilly ijreilly added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 5c3c2e0 Feb 13, 2026
85 of 87 checks passed
@ijreilly ijreilly deleted the fix--various-fixes-2 branch February 13, 2026 09:40
@twenty-eng-sync
Copy link
Copy Markdown

Hey @ijreilly! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

1 similar comment
@twenty-eng-sync
Copy link
Copy Markdown

Hey @ijreilly! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants