Fix index field comparison

[prastoin]

Introduction

Related twentyhq/core-team-issues#2227

On a field name update side effect leading to an index field mutation it wouldn't get caught by the builder leading to an index field desync

We should land on a standard pattern regarding the field index either jsonb or syncableEntity so this would not occur anymore as it would have been strictly typed

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:20806

This environment will automatically shut down when the PR is closed or after 5 hours.

[cubic-dev-ai]

No issues found across 2 files

[Weiko]

LGTM

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes a bug where index field metadata changes would not be detected during field name updates. The fix adds the missing universalProperty mapping for flatIndexFieldMetadatas → universalFlatIndexFieldMetadatas in the index configuration.

Key changes:

• Maps flatIndexFieldMetadatas to universalFlatIndexFieldMetadatas for proper comparison during workspace migrations
• Updates type definition to allow undefined | string for universal property, enabling non-standard mappings like this one
• Removes obsolete @ts-expect-error comment for labelIdentifierFieldMetadataId (now properly typed)
• Updates test snapshot to reflect the corrected property names used in comparison logic

The fix ensures that when a field name is updated, the side effect mutation to index fields is now properly detected by the builder, preventing index field desynchronization. The universalFlatIndexFieldMetadatas property is used for portable comparisons across workspace instances using universal identifiers instead of database IDs.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are straightforward and correct: adding a missing property mapping that should have existed based on the type definitions. The type system change (undefined | string) properly accommodates this mapping pattern. Test snapshot updated correctly. No breaking changes or side effects expected.
• No files require special attention

Important Files Changed

Filename	Overview
packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/all-entity-properties-configuration-by-metadata-name.constant.ts	Adds missing universalProperty mapping for flatIndexFieldMetadatas to universalFlatIndexFieldMetadatas, fixing index field comparison bug. Also removes unnecessary @ts-expect-error comment and adjusts type to allow string values.
packages/twenty-server/src/engine/metadata-modules/flat-entity/constant/tests/snapshots/all-universal-flat-entity-properties-to-compare-and-stringify.constant.spec.ts.snap	Updates test snapshot to reflect the corrected property name universalFlatIndexFieldMetadatas used for comparison and stringification.

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[etiennejouan]

👍

[twenty-eng-sync]

Hey @prastoin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[twenty-eng-sync]

Hey @prastoin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!