Skip to content

Fix hardcoded colors in 2FA verification screen for dark mode#17868

Merged
FelixMalfait merged 1 commit intomainfrom
fix-2fa-dash-color-dark-mode
Feb 11, 2026
Merged

Fix hardcoded colors in 2FA verification screen for dark mode#17868
FelixMalfait merged 1 commit intomainfrom
fix-2fa-dash-color-dark-mode

Conversation

@FelixMalfait
Copy link
Copy Markdown
Member

Summary

  • The dash separator and blinking caret in the sign-in 2FA OTP input had hardcoded black and white background colors, making them invisible in dark mode (black on black / white on white).
  • Replaced with theme-aware colors (theme.font.color.light for the dash, theme.font.color.primary for the caret) to match the existing settings 2FA component.

Test plan

  • Open the 2FA verification screen in dark mode and verify the dash between digit groups is visible
  • Verify the blinking caret is visible in dark mode
  • Confirm both still look correct in light mode

Made with Cursor

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@FelixMalfait FelixMalfait force-pushed the fix-2fa-dash-color-dark-mode branch 2 times, most recently from aac7e64 to 9711f5d Compare February 11, 2026 14:57
The dash and caret in the sign-in 2FA OTP input had hardcoded
`black` and `white` background colors, making them invisible
depending on theme. Replace with theme-aware colors
(`theme.font.color.primary` for the dash, `theme.font.color.light`
for the caret).

Co-authored-by: Cursor <cursoragent@cursor.com>
@FelixMalfait FelixMalfait force-pushed the fix-2fa-dash-color-dark-mode branch from 9711f5d to 1229a64 Compare February 11, 2026 14:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 11, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:30882

This environment will automatically shut down when the PR is closed or after 5 hours.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 11, 2026

Greptile Overview

Greptile Summary

This change updates the sign-in 2FA OTP verification UI to be theme-aware in dark mode by removing hardcoded black/white colors for the dash separator and blinking caret, replacing them with theme.font.color.light (dash) and theme.font.color.primary (caret). This matches the styling used by the Settings 2FA verification components and fixes invisibility in dark mode while preserving light-mode appearance.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The diff is limited to replacing hardcoded colors with existing theme tokens already used by the settings 2FA components; no logic or behavior changes were introduced.
  • No files require special attention

Important Files Changed

Filename Overview
packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpTwoFactorAuthenticationVerification.tsx Replaced hardcoded caret and dash colors with theme-aware tokens (theme.font.color.primary / theme.font.color.light) to fix dark-mode visibility; aligns with existing Settings 2FA components.

Sequence Diagram

sequenceDiagram
  participant User
  participant UI as SignInUpTOTPVerification
  participant Form as react-hook-form
  participant OTP as OTPInput
  participant Auth as useAuth

  User->>UI: Type OTP digits
  UI->>OTP: Render slots
  OTP-->>UI: Slot props (incl. fake caret)
  UI-->>User: Show dash + caret (theme colors)
  User->>UI: Submit form
  UI->>Form: handleSubmit
  Form-->>UI: OTP value
  UI->>Auth: Request tokens from OTP
  Auth-->>UI: Success or error
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@FelixMalfait FelixMalfait merged commit e757a14 into main Feb 11, 2026
51 of 54 checks passed
@FelixMalfait FelixMalfait deleted the fix-2fa-dash-color-dark-mode branch February 11, 2026 17:23
@twenty-eng-sync
Copy link
Copy Markdown

Hey @FelixMalfait! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant