Fix hardcoded colors in 2FA verification screen for dark mode#17868
Merged
FelixMalfait merged 1 commit intomainfrom Feb 11, 2026
Merged
Fix hardcoded colors in 2FA verification screen for dark mode#17868FelixMalfait merged 1 commit intomainfrom
FelixMalfait merged 1 commit intomainfrom
Conversation
aac7e64 to
9711f5d
Compare
.../modules/auth/sign-in-up/components/internal/SignInUpTwoFactorAuthenticationVerification.tsx
Outdated
Show resolved
Hide resolved
The dash and caret in the sign-in 2FA OTP input had hardcoded `black` and `white` background colors, making them invisible depending on theme. Replace with theme-aware colors (`theme.font.color.primary` for the dash, `theme.font.color.light` for the caret). Co-authored-by: Cursor <cursoragent@cursor.com>
9711f5d to
1229a64
Compare
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:30882 This environment will automatically shut down when the PR is closed or after 5 hours. |
Contributor
Greptile OverviewGreptile SummaryThis change updates the sign-in 2FA OTP verification UI to be theme-aware in dark mode by removing hardcoded Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant UI as SignInUpTOTPVerification
participant Form as react-hook-form
participant OTP as OTPInput
participant Auth as useAuth
User->>UI: Type OTP digits
UI->>OTP: Render slots
OTP-->>UI: Slot props (incl. fake caret)
UI-->>User: Show dash + caret (theme colors)
User->>UI: Submit form
UI->>Form: handleSubmit
Form-->>UI: OTP value
UI->>Auth: Request tokens from OTP
Auth-->>UI: Success or error
|
|
Hey @FelixMalfait! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blackandwhitebackground colors, making them invisible in dark mode (black on black / white on white).theme.font.color.lightfor the dash,theme.font.color.primaryfor the caret) to match the existing settings 2FA component.Test plan
Made with Cursor