Clean up and enhance logging for messaging and calendar#17498
Merged
charlesBochet merged 2 commits intomainfrom Jan 28, 2026
Merged
Clean up and enhance logging for messaging and calendar#17498charlesBochet merged 2 commits intomainfrom
charlesBochet merged 2 commits intomainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR improves logging for messaging and calendar import services by implementing a clearer logging strategy that reduces noise while improving debuggability. Key improvements:
The changes improve the signal-to-noise ratio in production logs by moving verbose operational details to debug level while ensuring critical errors remain visible at error level with better context. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant CalendarFetchEvents as Calendar Fetch Events Service
participant MessageListFetch as Message List Fetch Service
participant ExceptionHandler as Exception Handler Service
participant Logger as Logger (debug/error)
participant Sentry as Sentry (Exception Tracking)
Note over Client,Sentry: Before: Verbose log() calls everywhere
Client->>CalendarFetchEvents: Fetch calendar events
CalendarFetchEvents->>Logger: log() [routine operation]
CalendarFetchEvents->>Logger: log() [success message]
Note over Client,Sentry: After: Cleaner logging strategy
Client->>CalendarFetchEvents: Fetch calendar events
CalendarFetchEvents->>Logger: log() [operation start with WorkspaceId/CalendarChannelId]
CalendarFetchEvents->>Logger: debug() [routine details]
alt Error occurs
CalendarFetchEvents->>ExceptionHandler: Handle error
ExceptionHandler->>Logger: error() [with full context]
ExceptionHandler->>Sentry: Capture exception with metadata
Note over ExceptionHandler,Sentry: Includes: syncStep, throttleFailureCount, full IDs
end
Client->>MessageListFetch: Fetch message list
MessageListFetch->>Logger: log() [operation start with WorkspaceId/MessageChannelId]
MessageListFetch->>Logger: debug() [batch processing details]
MessageListFetch->>Logger: log() [operation summary]
alt Error occurs
MessageListFetch->>Logger: error() [structured error message]
Note over MessageListFetch,Logger: Format: WorkspaceId: X, MessageChannelId: Y - Error details
end
|
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:54067 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Jan 28, 2026
Contributor
LogDetails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces noise to signal ratio for messaging and calendar logging in production
Impact would be faster queries and debugging