Skip to content

[Debug log level] Print validation build result failure#17423

Merged
prastoin merged 3 commits intomainfrom
debug-validation-build-result
Jan 25, 2026
Merged

[Debug log level] Print validation build result failure#17423
prastoin merged 3 commits intomainfrom
debug-validation-build-result

Conversation

@prastoin
Copy link
Copy Markdown
Contributor

@prastoin prastoin commented Jan 25, 2026

Introduction

As per title, in order to ease debug
Motivation #17413 (comment)

@prastoin prastoin self-assigned this Jan 25, 2026
@prastoin prastoin marked this pull request as ready for review January 25, 2026 10:48
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 25, 2026

Greptile Overview

Greptile Summary

Added debug logging to output the full validation build result when migration validation fails. The log uses JSON.stringify with pretty-printing (2-space indentation) to make the failure details more readable for debugging purposes.

  • Logs validateAndBuildResult object containing the failure report with validation errors when status === 'fail'
  • Uses debug log level, which is appropriate for detailed diagnostic information
  • The logged data includes error codes, messages, and metadata about failed entity validations

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a single-line addition that adds debug logging for failed validation builds. It uses the appropriate log level (debug), doesn't modify any logic, and follows the existing logging patterns in the codebase. The logged data is already being returned from the function, so there's no risk of exposing additional information.
  • No files require special attention

Important Files Changed

Filename Overview
packages/twenty-server/src/engine/workspace-manager/workspace-migration/services/workspace-migration-validate-build-and-run-service.ts Added debug logging for validation build failures to aid debugging

Sequence Diagram

sequenceDiagram
    participant Client
    participant Service as WorkspaceMigrationValidateBuildAndRunService
    participant Orchestrator as WorkspaceMigrationBuildOrchestratorService
    participant Logger

    Client->>Service: validateBuildAndRunWorkspaceMigrationFromTo(args)
    Service->>Orchestrator: buildWorkspaceMigration(args)
    
    alt Build Validation Fails
        Orchestrator-->>Service: {status: 'fail', report: {...}}
        Service->>Logger: debug(JSON.stringify(validateAndBuildResult))
        Note over Logger: NEW: Logs detailed failure report for debugging
        Service-->>Client: return validateAndBuildResult
    else Build Validation Succeeds
        Orchestrator-->>Service: {status: 'success', workspaceMigration: {...}}
        alt Empty migration
            Service-->>Client: return undefined
        else Has migration actions
            Service->>Service: workspaceMigrationRunnerService.run(...)
            Service-->>Client: return undefined
        end
    end
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 25, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:24653

This environment will automatically shut down when the PR is closed or after 5 hours.

@prastoin prastoin added this pull request to the merge queue Jan 25, 2026
Merged via the queue into main with commit 3b51216 Jan 25, 2026
60 checks passed
@prastoin prastoin deleted the debug-validation-build-result branch January 25, 2026 11:22
prastoin added a commit that referenced this pull request Jan 25, 2026
# Introduction
As per title, in order to ease debug
Motivation
#17413 (comment)
abdulrahmancodes pushed a commit that referenced this pull request Jan 26, 2026
# Introduction
As per title, in order to ease debug
Motivation
#17413 (comment)
camilo-agudelo-uma pushed a commit to innovation-grupo-uma/twenty-uma that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants