fix: e2e login test - handle optional Continue with Email button#17146
Merged
charlesBochet merged 1 commit intomainfrom Jan 14, 2026
Merged
fix: e2e login test - handle optional Continue with Email button#17146charlesBochet merged 1 commit intomainfrom
charlesBochet merged 1 commit intomainfrom
Conversation
The SignInUpWorkspaceScopeFormEffect automatically skips the 'Continue with Email' step when password is the only auth method. The test now uses clickLoginWithEmailIfVisible() to handle both cases. Also updated the welcome text regex from 'Welcome to' to 'Welcome,' to match the recent UI change.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
charlesBochet
approved these changes
Jan 14, 2026
Member
Author
|
@charlesBochet I'm not sure if it will work, didn't test locally - wanted to use this PR to iterate, let's see if it's rejected from merge queue |
Member
|
let me run the e2e tests locally, should take 2mins |
|
Hey @FelixMalfait! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
1 similar comment
|
Hey @FelixMalfait! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
Member
All good! |
lucasbordeau
pushed a commit
to vasu1303/twenty
that referenced
this pull request
Jan 21, 2026
…ntyhq#17146) ## Summary The e2e login test was failing because it unconditionally tried to click 'Continue with Email' button, but this button doesn't exist when password is the only auth method. ## Root Cause In `SignInUpWorkspaceScopeFormEffect.tsx`, when a workspace only has password authentication (no Google/Microsoft/SSO), the effect automatically calls `continueWithEmail()` which skips the Init step and shows the email field directly. ## Changes 1. **loginPage.ts**: Added `clickLoginWithEmailIfVisible()` method that only clicks the button if it exists 2. **login.setup.ts**: - Replaced `clickLoginWithEmail()` with `clickLoginWithEmailIfVisible()` - Updated regex from `/Welcome to .+/` to `/Welcome, .+/` to match the recent UI change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e login test was failing because it unconditionally tried to click 'Continue with Email' button, but this button doesn't exist when password is the only auth method.
Root Cause
In
SignInUpWorkspaceScopeFormEffect.tsx, when a workspace only has password authentication (no Google/Microsoft/SSO), the effect automatically callscontinueWithEmail()which skips the Init step and shows the email field directly.Changes
clickLoginWithEmailIfVisible()method that only clicks the button if it existsclickLoginWithEmail()withclickLoginWithEmailIfVisible()/Welcome to .+/to/Welcome, .+/to match the recent UI change