Skip to content

refactor google refresh token service error handling#17127

Merged
charlesBochet merged 2 commits intomainfrom
enhance-google-refresh-token-error-handlng
Jan 13, 2026
Merged

refactor google refresh token service error handling#17127
charlesBochet merged 2 commits intomainfrom
enhance-google-refresh-token-error-handlng

Conversation

@neo773
Copy link
Copy Markdown
Member

@neo773 neo773 commented Jan 13, 2026

Refactors to be consistent with Microsoft service
Handles scenarios like temporary error which was not handled before
Moved IsGmailNetworkError from root orchestrator to driver level

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 13, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:39660

This environment will automatically shut down when the PR is closed or after 5 hours.

@charlesBochet
Copy link
Copy Markdown
Member

charlesBochet commented Jan 13, 2026

@neo773 could you please explain why you make the change? what was the issue and how this is solving it

Generally always add PR description, unless the title is enough

@neo773
Copy link
Copy Markdown
Member Author

neo773 commented Jan 13, 2026

@charlesBochet
Apologies, will come up with a system to ensure this doesn't happen again

Copy link
Copy Markdown
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesBochet charlesBochet added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit b79056b Jan 13, 2026
65 of 66 checks passed
@charlesBochet charlesBochet deleted the enhance-google-refresh-token-error-handlng branch January 13, 2026 18:36
@twenty-eng-sync
Copy link
Copy Markdown

Hey @neo773! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

1 similar comment
@twenty-eng-sync
Copy link
Copy Markdown

Hey @neo773! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

Thanks @neo773 for your contribution!
This marks your 93rd PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants