Invalidate legacy cache after flats#17126
Merged
charlesBochet merged 1 commit intomainfrom Jan 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:54019 This environment will automatically shut down when the PR is closed or after 5 hours. |
eba1ec0 to
3c82d40
Compare
charlesBochet
approved these changes
Jan 13, 2026
Member
|
Makes sense, LGTM |
1 similar comment
prastoin
added a commit
that referenced
this pull request
Jan 13, 2026
# Introduction Some legacy caches are based on the flat ones So we need to seq invalidate before invalidating others as it could result in inter dep cache invalidation race condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Some legacy caches are based on the flat ones
So we need to seq invalidate before invalidating others as it could result in inter dep cache invalidation race condition