Skip to content

Invalidate legacy cache after flats#17126

Merged
charlesBochet merged 1 commit intomainfrom
fix-workspace-migration-cache-invalidation-order
Jan 13, 2026
Merged

Invalidate legacy cache after flats#17126
charlesBochet merged 1 commit intomainfrom
fix-workspace-migration-cache-invalidation-order

Conversation

@prastoin
Copy link
Copy Markdown
Contributor

@prastoin prastoin commented Jan 13, 2026

Introduction

Some legacy caches are based on the flat ones
So we need to seq invalidate before invalidating others as it could result in inter dep cache invalidation race condition

@prastoin prastoin self-assigned this Jan 13, 2026
@prastoin prastoin marked this pull request as ready for review January 13, 2026 15:31
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 13, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:54019

This environment will automatically shut down when the PR is closed or after 5 hours.

@prastoin prastoin force-pushed the fix-workspace-migration-cache-invalidation-order branch from eba1ec0 to 3c82d40 Compare January 13, 2026 15:55
@charlesBochet
Copy link
Copy Markdown
Member

Makes sense, LGTM

@charlesBochet charlesBochet added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 46cf551 Jan 13, 2026
60 checks passed
@charlesBochet charlesBochet deleted the fix-workspace-migration-cache-invalidation-order branch January 13, 2026 16:19
@twenty-eng-sync
Copy link
Copy Markdown

Hey @prastoin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

1 similar comment
@twenty-eng-sync
Copy link
Copy Markdown

Hey @prastoin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

prastoin added a commit that referenced this pull request Jan 13, 2026
# Introduction

Some legacy caches are based on the flat ones
So we need to seq invalidate before invalidating others as it could
result in inter dep cache invalidation race condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants