fix: use theme-aware background color for billing credits progress bar#17103
Merged
charlesBochet merged 1 commit intomainfrom Jan 12, 2026
Merged
fix: use theme-aware background color for billing credits progress bar#17103charlesBochet merged 1 commit intomainfrom
charlesBochet merged 1 commit intomainfrom
Conversation
The progress bar background was hardcoded to BACKGROUND_LIGHT.tertiary, which caused it to always show a light color even in dark mode. Changed to use theme.background.tertiary to respect the current theme.
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
charlesBochet
approved these changes
Jan 12, 2026
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:45602 This environment will automatically shut down when the PR is closed or after 5 hours. |
|
Hey @charlesBochet! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BACKGROUND_LIGHT.tertiary, causing it to always display a light color regardless of the current themetheme.background.tertiaryto properly respect dark/light modeTest plan
Figma reference: https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=64812-242606&m=dev