[Dashboards] add primary axis select gap fill for bar and line charts

[ehconitin]

closes twentyhq/core-team-issues#2056

CleanShot.2026-01-12.at.20.29.02.mp4

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[cubic-dev-ai]

1 issue found across 11 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/fillSelectGapsInTwoDimensionalChartData.ts">

<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/fillSelectGapsInTwoDimensionalChartData.ts:33">
P1: Key collision vulnerability: Using underscore concatenation for Map keys can cause data corruption when dimension values contain underscores. Use JSON.stringify for reliable key generation.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: Key collision vulnerability: Using underscore concatenation for Map keys can cause data corruption when dimension values contain underscores. Use JSON.stringify for reliable key generation.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/modules/page-layout/widgets/graph/utils/fillSelectGapsInTwoDimensionalChartData.ts, line 33:

<comment>Key collision vulnerability: Using underscore concatenation for Map keys can cause data corruption when dimension values contain underscores. Use JSON.stringify for reliable key generation.</comment>

<file context>
@@ -0,0 +1,52 @@
+      | null;
+    uniqueSecondDimensionValues.add(secondDimensionValue);
+
+    const key = `${String(primaryDimensionValue)}_${String(secondDimensionValue)}`;
+    existingGroupsMap.set(key, item);
+  }
</file context>

Suggested change

	const key = `${String(primaryDimensionValue)}_${String(secondDimensionValue)}`;
	const key = JSON.stringify([primaryDimensionValue, secondDimensionValue]);

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:1686

This environment will automatically shut down when the PR is closed or after 5 hours.

[cubic-dev-ai]

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/page-layout/widgets/graph/graphWidgetLineChart/utils/transformGroupByDataToLineChartData.ts">

<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/graph/graphWidgetLineChart/utils/transformGroupByDataToLineChartData.ts:158">
P1: This change breaks gap filling for MULTI_SELECT fields. The original `isFieldMetadataSelectKind()` function checks for both SELECT and MULTI_SELECT types, but the new code only checks for SELECT. This will cause MULTI_SELECT fields to not have gaps filled in charts.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[charlesBochet]

LGTM regarding the code, I've left one nitpick comment, I'm testing locally now

[charlesBochet]

Tested the behavior, LGTM, merge when you are ready :)

[twenty-eng-sync]

Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[twenty-eng-sync]

Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[github-actions]

Thanks @ehconitin for your contribution!
This marks your 288th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter