feat(auth): Show Last used label on SSO sign-in method by ManikanthMartha · Pull Request #17093 · twentyhq/twenty

ManikanthMartha · 2026-01-12T11:43:43Z

Changes

Added lastAuthenticateWorkspaceSsoMethodState Recoil atom to track the last used SSO method, persisted in localStorage
Updated SignInUpWithGoogle component to display a "Last" pill badge when Google was the last auth method
Updated SignInUpWithMicrosoft component to display a "Last" pill badge when Microsoft was the last auth method
Updated SignInUpWithSSO component to display a "Last" pill badge when SSO was the last auth method.

The state is saved after successful authentication redirect, ensuring it persists across sessions

Implementation Details

Uses existing localStorageEffect for persistence across browser sessions
Leverages the existing Pill component from twenty-ui with blue accent color
The label is positioned on the right border of the button using absolute positioning
State is saved in the useAuth hook during Google/Microsoft sign-in and in the SSO login component

Note

Highlights the most recently used authentication method and preserves it across sessions.

Introduces AuthenticatedMethod enum and lastAuthenticatedMethodState (persisted via localStorageEffect) and preserves it through useAuth.clearSession
Displays a "Last" pill via LastUsedPill on SignInUpWithGoogle, SignInUpWithMicrosoft, SignInUpWithSSO, and SignInUpWithCredentials when appropriate; adds StyledSSOButtonContainer for badge positioning
Adds useHasMultipleAuthMethods to detect when to show the badge; threads isGlobalScope to relevant components
Sets last-used method on click/submit in SSO and credentials flows (useSignInUp, SSO button handlers)
Refactors SignInUpGlobalScopeForm to use SignInUpWithCredentials and updates SignInUp title logic for global scope (e.g., "Welcome to Twenty")

^{Written by Cursor Bugbot for commit 70d5527. This will update automatically on new commits. Configure here.}

…mponents

…cross sign-in components

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copilot

Pull request overview

This PR adds visual indicators ("Last" badges) to authentication buttons to help users identify which SSO method they used previously. The implementation creates a new Recoil atom that persists the last authenticated method to localStorage and displays a blue pill badge on the corresponding sign-in button.

Changes:

Added lastAuthenticatedMethodState Recoil atom with localStorage persistence to track last used auth method
Updated Google, Microsoft, and SSO sign-in components to show "Last" pill badges when they were the last used method
Modified logout flow in useAuth to preserve the last authenticated method across sessions

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
packages/twenty-front/src/modules/auth/states/lastAuthenticatedMethodState.ts	Defines new Recoil atom for tracking last authenticated method with localStorage persistence
packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx	Adds "Last" pill badge display and sets auth method on SSO button click
packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithMicrosoft.tsx	Adds "Last" pill badge display and sets auth method on Microsoft button click
packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithGoogle.tsx	Adds "Last" pill badge display and sets auth method on Google button click
packages/twenty-front/src/modules/auth/hooks/useAuth.ts	Preserves last authenticated method during logout by manually saving/restoring from localStorage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T11:49:13Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx

+    // Save to localStorage synchronously before redirect to ensure it persists
+    localStorage.setItem(
+      LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+      JSON.stringify('sso' as LastAuthenticatedMethod),
+    );


The logic for saving the last authenticated method to localStorage is duplicated across all three sign-in components (SSO, Microsoft, and Google). This manual localStorage manipulation bypasses the Recoil atom's effects. Consider using useSetRecoilState to set the lastAuthenticatedMethodState value instead, which would automatically handle persistence through the localStorageEffect and eliminate code duplication.

Copilot · 2026-01-12T11:49:13Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithMicrosoft.tsx

+const StyledButtonContainer = styled.div`
+  position: relative;
+  width: 100%;
+`;
+
+const StyledLastUsedPill = styled(Pill)`
+  position: absolute;
+  right: -${({ theme }) => theme.spacing(2)};
+  top: -${({ theme }) => theme.spacing(2)};
+  background: ${({ theme }) => theme.color.blue};
+  color: ${({ theme }) => theme.font.color.inverted};
+`;


The styled components StyledButtonContainer and StyledLastUsedPill are duplicated. This is the same issue as in the other sign-in components - these should be extracted into a shared styled component file.

Copilot · 2026-01-12T11:49:13Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithGoogle.tsx

+  const handleClick = () => {
+    // Save to localStorage synchronously before redirect to ensure it persists
+    localStorage.setItem(
+      LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+      JSON.stringify('google' as LastAuthenticatedMethod),
+    );
+    signInWithGoogle({ action });
+  };


The localStorage manipulation logic is duplicated. Instead of directly using localStorage.setItem with JSON.stringify, consider using useSetRecoilState to update the lastAuthenticatedMethodState, which would handle persistence automatically through the existing localStorageEffect.

Copilot · 2026-01-12T11:49:13Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithMicrosoft.tsx

+          variant={signInUpStep === SignInUpStep.Init ? undefined : 'secondary'}
+          fullWidth
+        />
+        {isLastUsed && <StyledLastUsedPill label={t`Last`} />}


The pill label displays "Last" but should display "Last used" to match the PR description and be more descriptive.

Suggested change

{isLastUsed && <StyledLastUsedPill label={t`Last`} />}

{isLastUsed && <StyledLastUsedPill label={t`Last used`} />}

Copilot · 2026-01-12T11:49:14Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithGoogle.tsx

+          variant={signInUpStep === SignInUpStep.Init ? undefined : 'secondary'}
+          fullWidth
+        />
+        {isLastUsed && <StyledLastUsedPill label={t`Last`} />}


The pill label displays "Last" but should display "Last used" to match the PR description and be more descriptive.

Suggested change

{isLastUsed && <StyledLastUsedPill label={t`Last`} />}

{isLastUsed && <StyledLastUsedPill label={t`Last used`} />}

Copilot · 2026-01-12T11:49:14Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx

+const StyledButtonContainer = styled.div`
+  position: relative;
+  width: 100%;
+`;
+
+const StyledLastUsedPill = styled(Pill)`
+  position: absolute;
+  right: -${({ theme }) => theme.spacing(2)};
+  top: -${({ theme }) => theme.spacing(2)};
+  background: ${({ theme }) => theme.color.blue};
+  color: ${({ theme }) => theme.font.color.inverted};
+`;


The styled components StyledButtonContainer and StyledLastUsedPill are duplicated across SignInUpWithSSO, SignInUpWithMicrosoft, and SignInUpWithGoogle components. Consider extracting these into a shared styled component file to reduce code duplication and ensure consistency.

Copilot · 2026-01-12T11:49:14Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithMicrosoft.tsx

+  const handleClick = () => {
+    // Save to localStorage synchronously before redirect to ensure it persists
+    localStorage.setItem(
+      LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+      JSON.stringify('microsoft' as LastAuthenticatedMethod),
+    );
+    signInWithMicrosoft({ action });
+  };


The localStorage manipulation logic is duplicated. Instead of directly using localStorage.setItem with JSON.stringify, consider using useSetRecoilState to update the lastAuthenticatedMethodState, which would handle persistence automatically through the existing localStorageEffect.

Copilot · 2026-01-12T11:49:14Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithGoogle.tsx

+const StyledButtonContainer = styled.div`
+  position: relative;
+  width: 100%;
+`;
+
+const StyledLastUsedPill = styled(Pill)`
+  position: absolute;
+  right: -${({ theme }) => theme.spacing(2)};
+  top: -${({ theme }) => theme.spacing(2)};
+  background: ${({ theme }) => theme.color.blue};
+  color: ${({ theme }) => theme.font.color.inverted};
+`;


The styled components StyledButtonContainer and StyledLastUsedPill are duplicated. This is the same issue as in the other sign-in components - these should be extracted into a shared styled component file.

Copilot · 2026-01-12T11:49:15Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx

+          variant={signInUpStep === SignInUpStep.Init ? undefined : 'secondary'}
+          fullWidth
+        />
+        {isLastUsed && <StyledLastUsedPill label={t`Last`} />}


The pill label displays "Last" but according to the PR title and description, it should display "Last used". Consider updating the label to be more descriptive and match the intended design.

Suggested change

{isLastUsed && <StyledLastUsedPill label={t`Last`} />}

{isLastUsed && <StyledLastUsedPill label={t`Last used`} />}

github-actions · 2026-01-12T11:55:09Z

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:32091

This environment will automatically shut down when the PR is closed or after 5 hours.

cubic-dev-ai

1 issue found across 5 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/auth/hooks/useAuth.ts">

<violation number="1" location="packages/twenty-front/src/modules/auth/hooks/useAuth.ts:181">
P2: Sign-out uses unguarded localStorage/sessionStorage calls that can throw (private mode/quota), aborting cleanup before tokens/cookies are cleared.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-12T11:55:52Z

packages/twenty-front/src/modules/auth/hooks/useAuth.ts

+        const lastAuthenticatedMethod = localStorage.getItem(
+          LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+        );
+
        sessionStorage.clear();
        localStorage.clear();
+
+        // Restore the last authenticated method after clearing
+        if (lastAuthenticatedMethod) {
+          localStorage.setItem(
+            LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+            lastAuthenticatedMethod,
+          );
+        }


P2: Sign-out uses unguarded localStorage/sessionStorage calls that can throw (private mode/quota), aborting cleanup before tokens/cookies are cleared.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/modules/auth/hooks/useAuth.ts, line 181: <comment>Sign-out uses unguarded localStorage/sessionStorage calls that can throw (private mode/quota), aborting cleanup before tokens/cookies are cleared.</comment> <file context> @@ -176,8 +177,22 @@ export const useAuth = () => { goToRecoilSnapshot(initialSnapshot); + // Preserve the last authenticated method before clearing localStorage + const lastAuthenticatedMethod = localStorage.getItem( + LAST_AUTHENTICATED_METHOD_STORAGE_KEY, + ); </file context>

Suggested change

const lastAuthenticatedMethod = localStorage.getItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

);

sessionStorage.clear();

localStorage.clear();

// Restore the last authenticated method after clearing

if (lastAuthenticatedMethod) {

localStorage.setItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

lastAuthenticatedMethod,

);

}

let lastAuthenticatedMethod: string | null = null;

try {

lastAuthenticatedMethod = localStorage.getItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

);

} catch {

lastAuthenticatedMethod = null;

}

try {

sessionStorage.clear();

localStorage.clear();

} catch {

// ignore storage errors during sign-out

}

if (lastAuthenticatedMethod) {

try {

localStorage.setItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

lastAuthenticatedMethod,

);

} catch {

// ignore failures preserving last auth method

}

}

✅ Addressed in 6b9e078

charlesBochet · 2026-01-12T12:55:28Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx

  const { redirectToSSOLoginPage } = useSSO();

  const signInWithSSO = () => {
+    // Save to localStorage synchronously before redirect to ensure it persists


remove comment

charlesBochet · 2026-01-12T12:55:41Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithMicrosoft.tsx

 import { useSignInWithMicrosoft } from '@/auth/sign-in-up/hooks/useSignInWithMicrosoft';
 import {
-  SignInUpStep,
-  signInUpStepState,


charlesBochet

@ManikanthMartha Thanks for opening a PR, could you first make sure the CI is red, it looks like you have added a lot of indentation that shouldn't be there

Also we don't add comments unless they are really needeed
Lastly, the design from your screenshot does not seems to be matching the one from the issue in term of colour/border. Please make sure it's pixel perfect by looking at the Figma. Could you also add a screenshot in light mode?

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useLastAuthenticatedMethod.ts

+  const setLastAuthenticatedMethod = (method: LastAuthenticatedMethod) => {
+    localStorage.setItem(
+      LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+      JSON.stringify(method),
+    );
+  };


cubic-dev-ai

1 issue found across 6 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/auth/sign-in-up/hooks/useLastAuthenticatedMethod.ts">

<violation number="1" location="packages/twenty-front/src/modules/auth/sign-in-up/hooks/useLastAuthenticatedMethod.ts:11">
P2: Setter bypasses Recoil state, writing only to localStorage so `lastAuthenticatedMethodState` stays stale until reload</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-12T13:03:52Z

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useLastAuthenticatedMethod.ts

+
+export const useLastAuthenticatedMethod = () => {
+  const lastAuthenticatedMethod = useRecoilValue(lastAuthenticatedMethodState);
+  const setLastAuthenticatedMethod = (method: LastAuthenticatedMethod) => {


P2: Setter bypasses Recoil state, writing only to localStorage so lastAuthenticatedMethodState stays stale until reload

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/modules/auth/sign-in-up/hooks/useLastAuthenticatedMethod.ts, line 11: <comment>Setter bypasses Recoil state, writing only to localStorage so `lastAuthenticatedMethodState` stays stale until reload</comment> <file context> @@ -0,0 +1,22 @@ + +export const useLastAuthenticatedMethod = () => { + const lastAuthenticatedMethod = useRecoilValue(lastAuthenticatedMethodState); + const setLastAuthenticatedMethod = (method: LastAuthenticatedMethod) => { + localStorage.setItem( + LAST_AUTHENTICATED_METHOD_STORAGE_KEY, </file context>

✅ Addressed in 7d62fbd

packages/twenty-front/src/modules/auth/hooks/useAuth.ts

          return undefined;
        });

        goToRecoilSnapshot(initialSnapshot);


charlesBochet · 2026-01-12T17:21:04Z

Could you please add screen recordings too? :)

ManikanthMartha · 2026-01-12T17:39:56Z

yea here is the screen recording.

Untitled.video.-.Made.with.Clipchamp.mp4

FelixMalfait · 2026-01-12T17:59:51Z

packages/twenty-front/src/modules/auth/states/lastAuthenticatedMethodState.ts

+import { atom } from 'recoil';
+import { localStorageEffect } from '~/utils/recoil/localStorageEffect';
+
+export type LastAuthenticatedMethod = 'google' | 'microsoft' | 'sso' | null;


One export max per file.

All caps enum AuthenticatedMethod = {
GOOGLE = 'GOOGLE'
...
}

FelixMalfait · 2026-01-12T18:00:20Z

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useLastAuthenticatedMethod.ts

+export const useLastAuthenticatedMethod = () => {
+  const lastAuthenticatedMethod = useRecoilValue(lastAuthenticatedMethodState);
+  const setLastAuthenticatedMethod = (method: LastAuthenticatedMethod) => {
+    localStorage.setItem(


The effect takes care of writing to local storage directly via the atom, you shouldn't access local storage directly

FelixMalfait · 2026-01-12T18:01:00Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx

+          variant={signInUpStep === SignInUpStep.Init ? undefined : 'secondary'}
+          fullWidth
+        />
+        {isLastUsed && <StyledLastUsedPill label={t`Last`} />}


If only a single method is enabled on that workspace then we probably shouldn't show last used

FelixMalfait · 2026-01-12T18:01:31Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx

    setSignInUpStep(SignInUpStep.SSOIdentityProviderSelection);
  };

+  const isLastUsed = lastAuthenticatedMethod === 'sso';


Never hardcode strings like that, instead reference the enum (e.g. AuthenticationMethod.SSO ...)

FelixMalfait · 2026-01-12T18:02:26Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithMicrosoft.tsx

  const { signInWithMicrosoft } = useSignInWithMicrosoft();

+  const handleClick = () => {
+    setLastAuthenticatedMethod('microsoft');


use ennum don't hardcode the string (same for other places)

FelixMalfait · 2026-01-12T21:44:50Z

packages/twenty-front/src/modules/auth/hooks/useAuth.ts

+          lastAuthenticatedMethod = localStorage.getItem(
+            LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+          );
+        } catch {


No need for try/catch like this

FelixMalfait · 2026-01-12T21:48:33Z

packages/twenty-ui/src/theme/constants/FontDark.ts

    extraLight: GRAY_SCALE_DARK.gray7,
    inverted: GRAY_SCALE_DARK.gray1,
    danger: COLOR_DARK.red,
+    indigo: COLOR_DARK.blue9,


We already use these colors, try maybe theme.color.blue? etc ; I don't think we need to introduce these

I had to introduce indigo as blue was not working for fonts

My bad, we can directly give the font color as color: ${({ theme }) => theme.color.blue}; , no need to introduce indigo

…thod handling

cubic-dev-ai

1 issue found across 7 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/auth/hooks/useAuth.ts">

<violation number="1" location="packages/twenty-front/src/modules/auth/hooks/useAuth.ts:181">
P1: Sign-out now unguardedly uses localStorage/sessionStorage; DOMException will abort sign-out flow leaving auth state uncleared</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-01-12T22:02:04Z

packages/twenty-front/src/modules/auth/hooks/useAuth.ts

+        const lastAuthenticatedMethod = localStorage.getItem(
+          LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+        );
+
        sessionStorage.clear();
        localStorage.clear();
+
+        if (lastAuthenticatedMethod !== null) {
+          localStorage.setItem(
+            LAST_AUTHENTICATED_METHOD_STORAGE_KEY,
+            lastAuthenticatedMethod,
+          );
+        }


P1: Sign-out now unguardedly uses localStorage/sessionStorage; DOMException will abort sign-out flow leaving auth state uncleared

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/modules/auth/hooks/useAuth.ts, line 181: <comment>Sign-out now unguardedly uses localStorage/sessionStorage; DOMException will abort sign-out flow leaving auth state uncleared</comment> <file context> @@ -177,31 +178,18 @@ export const useAuth = () => { - } catch { - // Ignore storage errors - last auth method is non-critical - } + const lastAuthenticatedMethod = localStorage.getItem( + LAST_AUTHENTICATED_METHOD_STORAGE_KEY, + ); </file context>

Suggested change

const lastAuthenticatedMethod = localStorage.getItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

);

sessionStorage.clear();

localStorage.clear();

if (lastAuthenticatedMethod !== null) {

localStorage.setItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

lastAuthenticatedMethod,

);

}

let lastAuthenticatedMethod: string | null = null;

try {

lastAuthenticatedMethod = localStorage.getItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

);

} catch {

lastAuthenticatedMethod = null;

}

try {

sessionStorage.clear();

localStorage.clear();

} catch {

// Ignore storage errors during sign-out

}

if (lastAuthenticatedMethod !== null) {

try {

localStorage.setItem(

LAST_AUTHENTICATED_METHOD_STORAGE_KEY,

lastAuthenticatedMethod,

);

} catch {

// Ignore failures preserving last auth method - it's non-critical

}

}

✅ Addressed in aae2da5

…and FONT_LIGHT

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithGoogle.tsx

+  const handleClick = () => {
+    setLastAuthenticatedMethod(AuthenticatedMethod.GOOGLE);
+    signInWithGoogle({ action });


cursor

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useHasMultipleAuthMethods.ts

FelixMalfait

Thank you!

cursor · 2026-01-13T21:13:01Z

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithGoogle.tsx

+    signInWithGoogle({ action });
+  };
+
+  const isLastUsed = lastAuthenticatedMethod === AuthenticatedMethod.GOOGLE;


Inconsistent step check for Last Used pill display

Medium Severity

The isLastUsed calculation in SignInUpWithGoogle, SignInUpWithMicrosoft, and SignInUpWithSSO doesn't check signInUpStep === SignInUpStep.Init, while SignInUpWithCredentials does include this check. This causes inconsistent behavior: when a user progresses to the Email or Password step, the Google/Microsoft/SSO buttons will still display the "Last" pill, but the credentials button won't. All authentication method buttons visible in the same view behave differently regarding when they show the indicator.

Additional Locations (2)

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithMicrosoft.tsx#L39-L40

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithSSO.tsx#L43-L44

cursor · 2026-01-13T21:13:01Z

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUp.ts


      const token = readCaptchaToken();
      try {
+        setLastAuthenticatedMethod(AuthenticatedMethod.EMAIL);


Last authenticated method set before success confirmation

Medium Severity

The setLastAuthenticatedMethod(AuthenticatedMethod.EMAIL) call in submitCredentials is placed before the authentication calls, inside the try block. If the sign-in fails (e.g., wrong password), the catch block shows an error but doesn't revert the state. This results in the "Last" indicator incorrectly showing email as the last used method even when the authentication attempt failed.

twenty-eng-sync · 2026-01-13T22:50:56Z

Hey @charlesBochet! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

github-actions · 2026-01-13T22:51:46Z

Thanks @ManikanthMartha for your contribution!
This marks your 3rd PR on the repo. You're top 9% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

ManikanthMartha added 4 commits January 12, 2026 09:22

feat: implement last authenticated method state and update sign-in co…

3c164f7

…mponents

refactor: reorganize imports in SignInUp components for consistency

dd1facb

feat: implement last authenticated method persistence in localStorage

520d068

refactor: reorder imports for last authenticated method consistency a…

cdc8b5d

…cross sign-in components

Copilot AI review requested due to automatic review settings January 12, 2026 11:43

greptile-apps bot reviewed Jan 12, 2026

View reviewed changes

Copilot started reviewing on behalf of ManikanthMartha January 12, 2026 11:44 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

cubic-dev-ai bot reviewed Jan 12, 2026

View reviewed changes

fix: resolved comments

6b9e078

charlesBochet reviewed Jan 12, 2026

View reviewed changes

charlesBochet added the -PR: awaiting author label Jan 12, 2026

charlesBochet self-assigned this Jan 12, 2026

sentry bot reviewed Jan 12, 2026

View reviewed changes

cubic-dev-ai bot reviewed Jan 12, 2026

View reviewed changes

ManikanthMartha added 3 commits January 12, 2026 15:22

fix lint, remove comments

a30a8d3

lint fix

039485a

lint

f547294

sentry bot reviewed Jan 12, 2026

View reviewed changes

packages/twenty-front/src/modules/auth/hooks/useAuth.ts

return undefined;

});

goToRecoilSnapshot(initialSnapshot);

This comment was marked as outdated.

Sign in to view

fix/styling

2efd5a9

FelixMalfait reviewed Jan 12, 2026

View reviewed changes

implement AuthenticatedMethod enum and refactor last authenticated me…

7d62fbd

…thod handling

cubic-dev-ai bot reviewed Jan 12, 2026

View reviewed changes

update color for StyledLastUsedPill and remove indigo from FONT_DARK …

e6dd2f4

…and FONT_LIGHT

sentry bot reviewed Jan 12, 2026

View reviewed changes

packages/twenty-front/src/modules/auth/sign-in-up/components/internal/SignInUpWithGoogle.tsx

Comment on lines +36 to +38

const handleClick = () => {

setLastAuthenticatedMethod(AuthenticatedMethod.GOOGLE);

signInWithGoogle({ action });

This comment was marked as outdated.

Sign in to view

charlesBochet assigned FelixMalfait and unassigned charlesBochet Jan 13, 2026

Fix write

aae2da5

charlesBochet added -PR: awaiting review and removed -PR: awaiting author labels Jan 13, 2026

Fixes

97809de

cursor bot reviewed Jan 13, 2026

View reviewed changes

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useHasMultipleAuthMethods.ts Show resolved Hide resolved

Improvements

70d5527

FelixMalfait force-pushed the feature/last-used-sso branch from ff6116e to 70d5527 Compare January 13, 2026 21:03

FelixMalfait approved these changes Jan 13, 2026

View reviewed changes

FelixMalfait enabled auto-merge January 13, 2026 21:06

cursor bot reviewed Jan 13, 2026

View reviewed changes

FelixMalfait added this pull request to the merge queue Jan 13, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026

charlesBochet merged commit 55cc7f8 into twentyhq:main Jan 13, 2026
64 checks passed

	{isLastUsed && <StyledLastUsedPill label={t`Last`} />}
	{isLastUsed && <StyledLastUsedPill label={t`Last used`} />}

Conversation

ManikanthMartha commented Jan 12, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Implementation Details

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charlesBochet left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

charlesBochet commented Jan 12, 2026

Uh oh!

ManikanthMartha commented Jan 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ManikanthMartha commented Jan 12, 2026 •

edited by cursor bot

Loading

github-actions bot commented Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading

cubic-dev-ai bot Jan 12, 2026 •

edited

Loading