Skip to content

Center lock icon when widget isn't accessible#17055

Merged
Devessier merged 1 commit intomainfrom
center-lock-icon
Jan 9, 2026
Merged

Center lock icon when widget isn't accessible#17055
Devessier merged 1 commit intomainfrom
center-lock-icon

Conversation

@Devessier
Copy link
Copy Markdown
Contributor

Before

CleanShot 2026-01-09 at 18 11 43@2x

After

CleanShot 2026-01-09 at 18 11 16@2x

Copilot AI review requested due to automatic review settings January 9, 2026 17:13
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Copy Markdown
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the visual presentation of widgets without access by centering the lock icon. The change wraps the lock icon in a flex container to center it both horizontally and vertically.

Key changes:

  • Added a styled component to center the lock icon when a widget isn't accessible
  • Wrapped the IconLock component in a centered flex container

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


const StyledNoAccessContainer = styled.div`
align-items: center;
display: flex;
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The StyledNoAccessContainer is missing a height property to properly center the icon vertically within the WidgetCardContent. Since WidgetCardContent has height: 100%, this container should also have height: 100% to ensure the icon is centered both horizontally and vertically across the full available space. Similar patterns in the codebase (e.g., GraphWidgetAggregateChart) include height: 100% when centering content with flexbox.

Suggested change
display: flex;
display: flex;
height: 100%;

Copilot uses AI. Check for mistakes.
@Devessier Devessier enabled auto-merge January 9, 2026 17:20
@Devessier Devessier added this pull request to the merge queue Jan 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:8366

This environment will automatically shut down when the PR is closed or after 5 hours.

Merged via the queue into main with commit 50eb639 Jan 9, 2026
75 checks passed
@Devessier Devessier deleted the center-lock-icon branch January 9, 2026 18:07
@twenty-eng-sync
Copy link
Copy Markdown

Hey @Devessier! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

1 similar comment
@twenty-eng-sync
Copy link
Copy Markdown

Hey @Devessier! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants