Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Author
LogDetails |
FelixMalfait
added a commit
that referenced
this pull request
Mar 25, 2026
PR #16997 replaced decorator-based workspace entities (which used msg`` for labels) with flat metadata builders using plain strings. The next automated lingui extract (PR #17025, 42 minutes later) removed all standard object label entries from the PO files, erasing their French translations. Restores 32 translations (Company→Entreprise, Person→Personne, etc.) from the state before erasure. Rewrites the integration test to verify actual French translations via the metadata API. Made-with: Cursor
FelixMalfait
added a commit
that referenced
this pull request
Mar 25, 2026
Restore 319 French translations that were erased in PR #17025 when lingui extract ran after PR #16997 removed msg`` from workspace entities. This includes object labels, field labels, and descriptions. Fix i18n integration test to update workspace member locale (the x-locale header is ignored for authenticated requests since userWorkspace.locale takes precedence). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action