Fix kanban view when grouping select field has null value#16998
Fix kanban view when grouping select field has null value#16998charlesBochet merged 3 commits intomainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-front/src/modules/object-record/record-group/utils/computeRecordGroupOptionsFilter.ts">
<violation number="1" location="packages/twenty-front/src/modules/object-record/record-group/utils/computeRecordGroupOptionsFilter.ts:37">
P2: When all values are null, `nonNullValues` will be an empty array, resulting in an unnecessary `{ in: [] }` filter condition. Consider only including the `in` filter when `nonNullValues` has elements.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
...twenty-front/src/modules/object-record/record-group/utils/computeRecordGroupOptionsFilter.ts
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
...twenty-front/src/modules/object-record/record-group/utils/computeRecordGroupOptionsFilter.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:42521 This environment will automatically shut down when the PR is closed or after 5 hours. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
...twenty-front/src/modules/object-record/record-group/utils/computeRecordGroupOptionsFilter.ts
Show resolved
Hide resolved
...twenty-front/src/modules/object-record/record-group/utils/computeRecordGroupOptionsFilter.ts
Outdated
Show resolved
Hide resolved
|
Could be cool to later add a story book test on this too |
|
Hey @etiennejouan! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
1 similar comment
|
Hey @etiennejouan! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
3 participants
No description provided.