Fix chart sorting

[bosiraphael]

I introduced a bug in the chart sorting in this PR: #16794
This PR fixes this.

The sorting on the first axis is already done by the group by for FIELD_ASC and FIELD_DESC. It is sorted also for the second axis but in each group.
For instance, if I create a graph that displays the amount of sales on each day of the week grouped by vendor
I can have for:
Monday: Vendor B, Vendor C
Tuesday: Vendor A, Vendor B
Wednesday: Vendor A, Vendor C
...
Inside each day the order of the vendor is correct, but by looking at only one day, I can't know the order of all the vendors.
That is why we always need to sort the second axis.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[cubic-dev-ai]

2 issues found across 8 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/sortTwoDimensionalChartPrimaryAxisDataByFieldOrManually.ts">

<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/sortTwoDimensionalChartPrimaryAxisDataByFieldOrManually.ts:54">
P1: This change will break the existing unit test `should sort by FIELD_ASC` in `sortTwoDimensionalChartPrimaryAxisDataByFieldOrManually.test.ts`. The test expects data to be sorted but the function now returns it unchanged. Either update the test to expect unchanged data (since sorting is done elsewhere per the PR description), or verify the code change is correct.</violation>
</file>

<file name="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/compareDimensionValues.ts">

<violation number="1" location="packages/twenty-front/src/modules/page-layout/widgets/graph/utils/compareDimensionValues.ts:10">
P1: The `parseDate` function can throw if the string is not a valid date format, but it claims to return `null` for invalid inputs. Since this is used in a comparison function for sorting, throwing here would crash the entire sort operation. Wrap the parsing in a try-catch to return `null` on failure.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:59344

This environment will automatically shut down when the PR is closed or after 5 hours.

[ehconitin]

lgtm

[twenty-eng-sync]

Hey @bosiraphael! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!