Merged
Conversation
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
10 issues found across 124 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-front/src/locales/cs-CZ.po">
<violation number="1" location="packages/twenty-front/src/locales/cs-CZ.po:3084">
P2: Missing Czech translation for "create". This string is used in error messages via `useMetadataErrorHandler.ts`. The Czech equivalent would be "vytvořit" to match the pattern of other action words in the file.</violation>
<violation number="2" location="packages/twenty-front/src/locales/cs-CZ.po:5302">
P2: Translation regression: This parameterized error message replaces a previously translated string but has no Czech translation. Czech users will see English text. Consider: "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Prosím, zkuste to znovu."</violation>
<violation number="3" location="packages/twenty-front/src/locales/cs-CZ.po:5307">
P2: Translation regression: This parameterized validation error message replaces a previously translated string but has no Czech translation. Consider: "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Přidružená ověření {relatedEntityNames} se nezdařila. Zkontrolujte prosím svou konfiguraci a zkuste to znovu."</violation>
<violation number="4" location="packages/twenty-front/src/locales/cs-CZ.po:9713">
P2: Missing Czech translation for "restore". The Czech equivalent would be "obnovit" to maintain consistency with other translated action words.</violation>
</file>
<file name="packages/twenty-front/src/locales/fr-FR.po">
<violation number="1" location="packages/twenty-front/src/locales/fr-FR.po:3084">
P2: Several new translation entries are missing French translations (empty `msgstr`). The entries for `create`, `restore`, `Failed to activate skill`, and the generic error messages with `{translatedOperationType}` placeholder need French translations to maintain localization consistency.</violation>
</file>
<file name="packages/twenty-front/src/locales/ko-KR.po">
<violation number="1" location="packages/twenty-front/src/locales/ko-KR.po:3084">
P2: Missing Korean translation for 'create'. Consider adding translation: `msgstr "생성"`</violation>
<violation number="2" location="packages/twenty-front/src/locales/ko-KR.po:5302">
P2: Missing Korean translation for refactored error message. This replaces a previously translated string, causing a UX regression for Korean users. Consider adding translation based on the pattern: `msgstr "{translatedMetadataName} {translatedOperationType}에 실패하였습니다. 다시 시도해주세요."`</violation>
<violation number="3" location="packages/twenty-front/src/locales/ko-KR.po:5307">
P2: Missing Korean translation for refactored validation error message. This replaces a previously translated string, causing a UX regression for Korean users.</violation>
</file>
<file name="packages/twenty-front/src/locales/de-DE.po">
<violation number="1" location="packages/twenty-front/src/locales/de-DE.po:3084">
P2: Missing German translation for 'create'. For consistency with other action verbs (delete→löschen, destroy→zerstören, update→aktualisieren), this should be translated to 'erstellen'.</violation>
<violation number="2" location="packages/twenty-front/src/locales/de-DE.po:5302">
P2: Missing German translation for generic error message. The previous specific 'Failed to create...' message had a translation ('Das Erstellen von {translatedMetadataName} ist fehlgeschlagen. Bitte versuchen Sie es erneut.') which was lost in this refactoring. Consider adapting it for the new generic format.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Comment on lines
+9713
to
+9714
| msgid "restore" | ||
| msgstr "" |
Contributor
There was a problem hiding this comment.
P2: Missing Czech translation for "restore". The Czech equivalent would be "obnovit" to maintain consistency with other translated action words.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/cs-CZ.po, line 9713:
<comment>Missing Czech translation for "restore". The Czech equivalent would be "obnovit" to maintain consistency with other translated action words.</comment>
<file context>
@@ -9700,6 +9708,11 @@ msgstr "Restartovat"
+#. js-lingui-id: o7CJMO
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "restore"
+msgstr ""
+
</file context>
Suggested change
| msgid "restore" | |
| msgstr "" | |
| msgid "restore" | |
| msgstr "obnovit" |
| #. js-lingui-id: gJdfqX | ||
| #: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts | ||
| msgid "create" | ||
| msgstr "" |
Contributor
There was a problem hiding this comment.
P2: Missing Czech translation for "create". This string is used in error messages via useMetadataErrorHandler.ts. The Czech equivalent would be "vytvořit" to match the pattern of other action words in the file.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/cs-CZ.po, line 3084:
<comment>Missing Czech translation for "create". This string is used in error messages via `useMetadataErrorHandler.ts`. The Czech equivalent would be "vytvořit" to match the pattern of other action words in the file.</comment>
<file context>
@@ -3077,6 +3078,11 @@ msgstr "Země"
+#. js-lingui-id: gJdfqX
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "create"
+msgstr ""
+
#. js-lingui-id: hYgDIe
</file context>
Suggested change
| msgstr "" | |
| msgstr "vytvořit" |
Comment on lines
+5307
to
+5308
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Related {relatedEntityNames} validation failed. Please check your configuration and try again." | ||
| msgstr "" |
Contributor
There was a problem hiding this comment.
P2: Translation regression: This parameterized validation error message replaces a previously translated string but has no Czech translation. Consider: "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Přidružená ověření {relatedEntityNames} se nezdařila. Zkontrolujte prosím svou konfiguraci a zkuste to znovu."
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/cs-CZ.po, line 5307:
<comment>Translation regression: This parameterized validation error message replaces a previously translated string but has no Czech translation. Consider: "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Přidružená ověření {relatedEntityNames} se nezdařila. Zkontrolujte prosím svou konfiguraci a zkuste to znovu."</comment>
<file context>
@@ -5289,20 +5297,20 @@ msgstr "Selhalo"
#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
-msgid "Failed to create {translatedMetadataName}. Please try again."
-msgstr "Nepodařilo se vytvořit {translatedMetadataName}. Prosím, zkuste to znovu."
+msgid "Failed to {translatedOperationType} {translatedMetadataName}. Related {relatedEntityNames} validation failed. Please check your configuration and try again."
+msgstr ""
</file context>
Suggested change
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Related {relatedEntityNames} validation failed. Please check your configuration and try again." | |
| msgstr "" | |
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Related {relatedEntityNames} validation failed. Please check your configuration and try again." | |
| msgstr "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Přidružená ověření {relatedEntityNames} se nezdařila. Zkontrolujte prosím svou konfiguraci a zkuste to znovu." |
Comment on lines
+5302
to
5303
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again." | ||
| msgstr "" |
Contributor
There was a problem hiding this comment.
P2: Translation regression: This parameterized error message replaces a previously translated string but has no Czech translation. Czech users will see English text. Consider: "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Prosím, zkuste to znovu."
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/cs-CZ.po, line 5302:
<comment>Translation regression: This parameterized error message replaces a previously translated string but has no Czech translation. Czech users will see English text. Consider: "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Prosím, zkuste to znovu."</comment>
<file context>
@@ -5289,20 +5297,20 @@ msgstr "Selhalo"
-msgid "Failed to activate skill"
+#. js-lingui-id: QvHpKb
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again."
msgstr ""
</file context>
Suggested change
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again." | |
| msgstr "" | |
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again." | |
| msgstr "Nepodařilo se {translatedOperationType} {translatedMetadataName}. Prosím, zkuste to znovu." |
| @@ -1426,6 +1426,7 @@ msgstr "Une erreur s'est produite lors du téléversement de l'image." | |||
| #: src/modules/settings/serverless-functions/hooks/usePersistServerlessFunction.ts | |||
Contributor
There was a problem hiding this comment.
P2: Several new translation entries are missing French translations (empty msgstr). The entries for create, restore, Failed to activate skill, and the generic error messages with {translatedOperationType} placeholder need French translations to maintain localization consistency.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/fr-FR.po, line 3084:
<comment>Several new translation entries are missing French translations (empty `msgstr`). The entries for `create`, `restore`, `Failed to activate skill`, and the generic error messages with `{translatedOperationType}` placeholder need French translations to maintain localization consistency.</comment>
<file context>
@@ -3077,6 +3078,11 @@ msgstr "Pays"
+#. js-lingui-id: gJdfqX
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "create"
+msgstr ""
+
#. js-lingui-id: hYgDIe
</file context>
| #. js-lingui-id: gJdfqX | ||
| #: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts | ||
| msgid "create" | ||
| msgstr "" |
Contributor
There was a problem hiding this comment.
P2: Missing Korean translation for 'create'. Consider adding translation: msgstr "생성"
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/ko-KR.po, line 3084:
<comment>Missing Korean translation for 'create'. Consider adding translation: `msgstr "생성"`</comment>
<file context>
@@ -3077,6 +3078,11 @@ msgstr "국가"
+#. js-lingui-id: gJdfqX
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "create"
+msgstr ""
+
#. js-lingui-id: hYgDIe
</file context>
Suggested change
| msgstr "" | |
| msgstr "생성" |
| #: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts | ||
| msgid "Failed to create {translatedMetadataName}. Please try again." | ||
| msgstr "{translatedMetadataName} 생성에 실패하였습니다. 다시 시도해주세요." | ||
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Related {relatedEntityNames} validation failed. Please check your configuration and try again." |
Contributor
There was a problem hiding this comment.
P2: Missing Korean translation for refactored validation error message. This replaces a previously translated string, causing a UX regression for Korean users.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/ko-KR.po, line 5307:
<comment>Missing Korean translation for refactored validation error message. This replaces a previously translated string, causing a UX regression for Korean users.</comment>
<file context>
@@ -5289,20 +5297,20 @@ msgstr "실패"
#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
-msgid "Failed to create {translatedMetadataName}. Please try again."
-msgstr "{translatedMetadataName} 생성에 실패하였습니다. 다시 시도해주세요."
+msgid "Failed to {translatedOperationType} {translatedMetadataName}. Related {relatedEntityNames} validation failed. Please check your configuration and try again."
+msgstr ""
</file context>
| msgid "Failed to activate skill" | ||
| #. js-lingui-id: QvHpKb | ||
| #: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts | ||
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again." |
Contributor
There was a problem hiding this comment.
P2: Missing Korean translation for refactored error message. This replaces a previously translated string, causing a UX regression for Korean users. Consider adding translation based on the pattern: msgstr "{translatedMetadataName} {translatedOperationType}에 실패하였습니다. 다시 시도해주세요."
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/ko-KR.po, line 5302:
<comment>Missing Korean translation for refactored error message. This replaces a previously translated string, causing a UX regression for Korean users. Consider adding translation based on the pattern: `msgstr "{translatedMetadataName} {translatedOperationType}에 실패하였습니다. 다시 시도해주세요."`</comment>
<file context>
@@ -5289,20 +5297,20 @@ msgstr "실패"
-msgid "Failed to activate skill"
+#. js-lingui-id: QvHpKb
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again."
msgstr ""
</file context>
| #. js-lingui-id: gJdfqX | ||
| #: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts | ||
| msgid "create" | ||
| msgstr "" |
Contributor
There was a problem hiding this comment.
P2: Missing German translation for 'create'. For consistency with other action verbs (delete→löschen, destroy→zerstören, update→aktualisieren), this should be translated to 'erstellen'.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/de-DE.po, line 3084:
<comment>Missing German translation for 'create'. For consistency with other action verbs (delete→löschen, destroy→zerstören, update→aktualisieren), this should be translated to 'erstellen'.</comment>
<file context>
@@ -3077,6 +3078,11 @@ msgstr "Land"
+#. js-lingui-id: gJdfqX
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "create"
+msgstr ""
+
#. js-lingui-id: hYgDIe
</file context>
Suggested change
| msgstr "" | |
| msgstr "erstellen" |
| msgid "Failed to activate skill" | ||
| #. js-lingui-id: QvHpKb | ||
| #: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts | ||
| msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again." |
Contributor
There was a problem hiding this comment.
P2: Missing German translation for generic error message. The previous specific 'Failed to create...' message had a translation ('Das Erstellen von {translatedMetadataName} ist fehlgeschlagen. Bitte versuchen Sie es erneut.') which was lost in this refactoring. Consider adapting it for the new generic format.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/de-DE.po, line 5302:
<comment>Missing German translation for generic error message. The previous specific 'Failed to create...' message had a translation ('Das Erstellen von {translatedMetadataName} ist fehlgeschlagen. Bitte versuchen Sie es erneut.') which was lost in this refactoring. Consider adapting it for the new generic format.</comment>
<file context>
@@ -5289,20 +5297,20 @@ msgstr "Fehlgeschlagen"
-msgid "Failed to activate skill"
+#. js-lingui-id: QvHpKb
+#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
+msgid "Failed to {translatedOperationType} {translatedMetadataName}. Please try again."
msgstr ""
</file context>
Contributor
|
Too many files changed for review. |
6 similar comments
Contributor
|
Too many files changed for review. |
Contributor
|
Too many files changed for review. |
Contributor
|
Too many files changed for review. |
Contributor
|
Too many files changed for review. |
Contributor
|
Too many files changed for review. |
Contributor
|
Too many files changed for review. |
Contributor
|
Too many files changed for review. |
Contributor
Author
LogDetails |
Contributor
|
Too many files changed for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action