Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.ts">
<violation number="1" location="packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.ts:118">
P1: Missing `await` on transaction call. The transaction will execute asynchronously without waiting for completion, which can cause race conditions and data inconsistency issues during workspace initialization.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.ts
Outdated
Show resolved
Hide resolved
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:4231 This environment will automatically shut down when the PR is closed or after 5 hours. |
Contributor
Author
|
@cubic-dev-ai please review |
Contributor
@prastoin I have started the AI code review. It will take a few minutes to complete. |
Weiko
approved these changes
Jan 7, 2026
| }, | ||
| ); | ||
|
|
||
| const queryRunner = this.coreDataSource.createQueryRunner(); |
Member
There was a problem hiding this comment.
I'm assuming this was like this before but ideally we should use the workspace global datasource and inject the workspace context and not use the core datasource for record pre-filling @prastoin
prastoin
added
-PR: awaiting review
-PR: awaiting CI
and removed
-PR: awaiting author
labels
1 similar comment
etiennejouan
pushed a commit
that referenced
this pull request
Jan 7, 2026
# Introduction Fixing prefill in v2 workspace creation code flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Fixing prefill in v2 workspace creation code flow