Skip to content

Add metrics for completed and failed jobs#16969

Merged
charlesBochet merged 3 commits intomainfrom
tt-add-metrics-for-completed-and-failed-jobs
Jan 6, 2026
Merged

Add metrics for completed and failed jobs#16969
charlesBochet merged 3 commits intomainfrom
tt-add-metrics-for-completed-and-failed-jobs

Conversation

@thomtrp
Copy link
Copy Markdown
Contributor

@thomtrp thomtrp commented Jan 6, 2026

Add a counter for completed and failed jobs

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:49089

This environment will automatically shut down when the PR is closed or after 5 hours.

Copy link
Copy Markdown
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

);

this.workerMap[queueName].on('completed', (job) => {
if (this.metricsService) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this?
If so, prefer isDefined maybe?

@thomtrp thomtrp force-pushed the tt-add-metrics-for-completed-and-failed-jobs branch from b564723 to a9bb172 Compare January 6, 2026 17:04
@thomtrp thomtrp force-pushed the tt-add-metrics-for-completed-and-failed-jobs branch from a9bb172 to c74cbeb Compare January 6, 2026 17:05
@thomtrp thomtrp enabled auto-merge January 6, 2026 17:06
@thomtrp thomtrp disabled auto-merge January 6, 2026 17:09
@Weiko Weiko added this pull request to the merge queue Jan 6, 2026
@thomtrp thomtrp removed this pull request from the merge queue due to a manual request Jan 6, 2026
@thomtrp thomtrp added this pull request to the merge queue Jan 6, 2026
Copy link
Copy Markdown
Contributor

@etiennejouan etiennejouan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@charlesBochet charlesBochet added this pull request to the merge queue Jan 6, 2026
@charlesBochet charlesBochet removed this pull request from the merge queue due to a manual request Jan 6, 2026
@charlesBochet charlesBochet merged commit 6043edd into main Jan 6, 2026
60 checks passed
@charlesBochet charlesBochet deleted the tt-add-metrics-for-completed-and-failed-jobs branch January 6, 2026 17:51
@twenty-eng-sync
Copy link
Copy Markdown

Hey @thomtrp! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants