Add metrics for completed and failed jobs#16969
Merged
charlesBochet merged 3 commits intomainfrom Jan 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
packages/twenty-server/src/engine/core-modules/message-queue/drivers/bullmq.driver.ts
Show resolved
Hide resolved
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:49089 This environment will automatically shut down when the PR is closed or after 5 hours. |
Weiko
approved these changes
Jan 6, 2026
| ); | ||
|
|
||
| this.workerMap[queueName].on('completed', (job) => { | ||
| if (this.metricsService) { |
Member
There was a problem hiding this comment.
Do you still need this?
If so, prefer isDefined maybe?
b564723 to
a9bb172
Compare
a9bb172 to
c74cbeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a counter for completed and failed jobs