Skip to content

Update dashboard Icons#16605

Merged
bosiraphael merged 1 commit intomainfrom
r--update-icons
Dec 16, 2025
Merged

Update dashboard Icons#16605
bosiraphael merged 1 commit intomainfrom
r--update-icons

Conversation

@bosiraphael
Copy link
Copy Markdown
Contributor

New Icons:

CleanShot 2025-12-16 at 15 53 45@2x CleanShot 2025-12-16 at 15 54 19@2x CleanShot 2025-12-16 at 15 53 56@2x

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Comment on lines 25 to 31
IconAt,
IconAxisX,
IconAxisY,
IconBadge2k,
IconBaselineDensitySmall,
IconBell,
IconBlockquote,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The import of IconBadge2k will fail because it was introduced in v3.23 of @tabler/icons-react, but the project's dependency constraint is ^3.31.0, making the icon unavailable.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The code imports IconBadge2k from @tabler/icons-react. However, the project's package.json specifies a dependency on version ^3.31.0 of this library, which resolves to versions greater than or equal to 3.31.0 and less than 4.0.0. The IconBadge2k icon was introduced in an older version, v3.23. As a result, the icon is not present in the allowed version range, and the import will fail with a "Module has no exported member" error. This will cause the application to fail during the build process or at runtime.

💡 Suggested Fix

To resolve this, either replace IconBadge2k with an icon that is available in @tabler/icons-react version ^3.31.0, or adjust the dependency version in package.json to a range that includes the version where IconBadge2k was introduced, after verifying it doesn't cause other compatibility issues.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/twenty-ui/src/display/icon/components/TablerIcons.ts#L25-L31

Potential issue: The code imports `IconBadge2k` from `@tabler/icons-react`. However, the
project's `package.json` specifies a dependency on version `^3.31.0` of this library,
which resolves to versions greater than or equal to 3.31.0 and less than 4.0.0. The
`IconBadge2k` icon was introduced in an older version, v3.23. As a result, the icon is
not present in the allowed version range, and the import will fail with a "Module has no
exported member" error. This will cause the application to fail during the build process
or at runtime.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7591579

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Copy link
Copy Markdown
Contributor

@ehconitin ehconitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bosiraphael bosiraphael merged commit 5a5bf11 into main Dec 16, 2025
72 checks passed
@bosiraphael bosiraphael deleted the r--update-icons branch December 16, 2025 15:57
@twenty-eng-sync
Copy link
Copy Markdown

Hey @bosiraphael! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants