Feature 15797 add secondary action button by Lakshayyy-m · Pull Request #16582 · twentyhq/twenty

Lakshayyy-m · 2025-12-16T05:08:48Z

This is a fix for #15797

This pull request is to replace PR #16307 and to extend #16265

Just to repeat, this PR does the following ->
Table Cell Button and Edit Button Improvements

Enhanced RecordTableCellButton to support a secondary action and icon, enabling both the primary and secondary actions based on the selected action mode.
Updated RecordTableCellEditButton to determine the action mode for actionable fields, and provide both copy and navigate actions as primary/secondary buttons, with appropriate feedback.

When primary function is to copy

When primary function is to open link

Hey @etiennejouan, please have a look!
Thank you

…if any

… safely

…tors

…cards

…if any

…tors

…ithub.com/Lakshayyy-m/twenty into feature-15797-add-secondary-action-button

…button

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

cubic-dev-ai

No issues found across 4 files

Copilot

Pull request overview

This PR adds support for secondary action buttons in table cells for phone, email, and link fields. It enables users to toggle between copy and navigate actions based on the field's configured click action setting.

Enhanced RecordTableCellButton to support optional secondary action buttons using LightIconButtonGroup
Extended RecordTableCellEditButton to provide both copy and navigate actions as primary/secondary buttons for phone, email, and link fields based on their configured click action
Added I18n decorator to storybook configuration and removed isDisplayModeFixHeight from default context values

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`RecordTableCellEditButton.tsx`	Added logic to determine primary/secondary actions (copy/navigate) based on field type and click action configuration
`RecordTableCellButton.tsx`	Refactored to use `LightIconButtonGroup` for rendering multiple action buttons and added border styling
`RecordInlineCellContext.tsx`	Removed `isDisplayModeFixHeight` from default context values
`SettingsDataModelFieldPreviewWidget.stories.tsx`	Added `I18nFrontDecorator` for internationalization support

Comments suppressed due to low confidence (2)

packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditButton.tsx:27

Unused variable enqueueSuccessSnackBar.

  const { enqueueSuccessSnackBar, enqueueErrorSnackBar } = useSnackBar();

packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellEditButton.tsx:27

Unused variable enqueueErrorSnackBar.

  const { enqueueSuccessSnackBar, enqueueErrorSnackBar } = useSnackBar();

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...odules/object-record/record-table/record-table-cell/components/RecordTableCellEditButton.tsx

...ty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContext.tsx

...odules/object-record/record-table/record-table-cell/components/RecordTableCellEditButton.tsx

etiennejouan · 2025-12-16T16:05:47Z

...ty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContext.tsx

  editModeContent: undefined,
  editModeContentOnly: false,
  displayModeContent: undefined,
-  isDisplayModeFixHeight: false,


@Lakshayyy-m Why do you remove this default prop ?

etiennejouan

@Lakshayyy-m Thanks a lot for your contribution ! 🙏
As you already do extra work with rebase, I update myself rather than commenting. I simply move the secondary button action logic in a dedicated hook.

Thank you for your work and patience !

Lakshayyy-m · 2025-12-17T04:20:44Z

Hey @etiennejouan,
Thank you for making those changes. And I honestly wouldn't have minded, it's a learning opportunity for me. Let me know if I can help anymore!

twenty-eng-sync · 2025-12-17T08:13:14Z

Hey @etiennejouan! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

github-actions · 2025-12-17T08:14:03Z

Thanks @Lakshayyy-m for your contribution!
This marks your 1st PR on the repo. You're top 38% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

etiennejouan · 2025-12-17T08:14:57Z

Hey @etiennejouan, Thank you for making those changes. And I honestly wouldn't have minded, it's a learning opportunity for me. Let me know if I can help anymore!

@Lakshayyy-m, congrats for your first merged PR ! 👏
Please feel free to tackle other issues !

Merged #16582 without testing case when fieldDefinition.metadata.settings?.clickAction is not set (default value) To test : When <img width="548" height="537" alt="Screenshot 2025-12-17 at 09 37 26" src="https://github.com/user-attachments/assets/96a85093-24bb-4436-9000-340cd020e343" /> is set (or default) In table view you can copy cell content <img width="252" height="77" alt="Screenshot 2025-12-17 at 09 36 58" src="https://github.com/user-attachments/assets/44b938f3-74b8-4d58-8b1a-344b4f39bfbd" />

@etiennejouan

This is a fix for #15797 This pull request is to replace PR #16307 and to extend #16265 Just to repeat, this PR does the following -> **Table Cell Button and Edit Button Improvements** - Enhanced RecordTableCellButton to support a secondary action and icon, enabling both the primary and secondary actions based on the selected action mode. - Updated RecordTableCellEditButton to determine the action mode for actionable fields, and provide both copy and navigate actions as primary/secondary buttons, with appropriate feedback. ## When primary function is to copy <img width="1817" height="939" alt="image" src="https://github.com/user-attachments/assets/7ec6c6aa-80d8-402b-a210-519163d39ef6" /> ## When primary function is to open link <img width="1784" height="942" alt="image" src="https://github.com/user-attachments/assets/dfe0fcf1-ba72-4083-a5f9-7165a03db3df" /> Hey @etiennejouan, please have a look! Thank you --------- Co-authored-by: Etienne <45695613+etiennejouan@users.noreply.github.com>

Merged #16582 without testing case when fieldDefinition.metadata.settings?.clickAction is not set (default value) To test : When <img width="548" height="537" alt="Screenshot 2025-12-17 at 09 37 26" src="https://github.com/user-attachments/assets/96a85093-24bb-4436-9000-340cd020e343" /> is set (or default) In table view you can copy cell content <img width="252" height="77" alt="Screenshot 2025-12-17 at 09 36 58" src="https://github.com/user-attachments/assets/44b938f3-74b8-4d58-8b1a-344b4f39bfbd" />

Lakshayyy-m added 12 commits December 4, 2025 08:51

feat: implement action mode for field displays and settings forms

9517d9e

fix: Remove unnecessary commenting, console logs and inconsistencies …

0109bb6

…if any

refactor: improve deepMergeZod function to handle object schemas more…

b4df3ff

… safely

feat: update icons for clipboard actions and enhance storybook decora…

1cb6205

…tors

feat: remove disabled prop from primary action mode form in settings …

e7e1171

…cards

- refined the action button user message and icons

e6aab6a

feat: implement action mode for field displays and settings forms

ef1feef

fix: Remove unnecessary commenting, console logs and inconsistencies …

5b821dd

…if any

feat: update icons for clipboard actions and enhance storybook decora…

a39241a

…tors

Merge branch 'feature-15797-add-secondary-action-button' of https://g…

0f53f5f

…ithub.com/Lakshayyy-m/twenty into feature-15797-add-secondary-action-button

- Added second action button based on field primary action type

66b339e

Merge branch 'twentyhq:main' into feature-15797-add-secondary-action-…

171aa30

…button

Copilot AI review requested due to automatic review settings December 16, 2025 05:08

greptile-apps bot reviewed Dec 16, 2025

View reviewed changes

Copilot started reviewing on behalf of Lakshayyy-m December 16, 2025 05:09 View session

cubic-dev-ai bot reviewed Dec 16, 2025

View reviewed changes

Copilot AI reviewed Dec 16, 2025

View reviewed changes

etiennejouan self-assigned this Dec 16, 2025

move logic in dedicated hook + fix lint

4028039

sentry bot reviewed Dec 16, 2025

View reviewed changes

...odules/object-record/record-table/record-table-cell/components/RecordTableCellEditButton.tsx Show resolved Hide resolved

etiennejouan reviewed Dec 16, 2025

View reviewed changes

etiennejouan approved these changes Dec 16, 2025

View reviewed changes

etiennejouan added 2 commits December 16, 2025 17:08

restore default prop

ff87bb5

fix

40f52f8

etiennejouan added the -PR: awaiting author label Dec 16, 2025

Merge branch 'main' into feature-15797-add-secondary-action-button

2924eb6

etiennejouan merged commit d43e21b into twentyhq:main Dec 17, 2025
61 checks passed

etiennejouan mentioned this pull request Dec 17, 2025

Second Action Button - fix #16613

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature 15797 add secondary action button#16582

Feature 15797 add secondary action button#16582
etiennejouan merged 16 commits intotwentyhq:mainfrom
Lakshayyy-m:feature-15797-add-secondary-action-button

Lakshayyy-m commented Dec 16, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etiennejouan Dec 16, 2025

Uh oh!

etiennejouan left a comment •

edited

Loading

Uh oh!

Lakshayyy-m commented Dec 17, 2025

Uh oh!

Uh oh!

twenty-eng-sync bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

etiennejouan commented Dec 17, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Lakshayyy-m commented Dec 16, 2025

When primary function is to copy

When primary function is to open link

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etiennejouan Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

etiennejouan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lakshayyy-m commented Dec 17, 2025

Uh oh!

Uh oh!

twenty-eng-sync bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

etiennejouan commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

etiennejouan left a comment •

edited

Loading

etiennejouan commented Dec 17, 2025 •

edited

Loading