feat: add full path label tooltip for workflow filter field#16580
Merged
Devessier merged 6 commits intotwentyhq:mainfrom Dec 17, 2025
Merged
feat: add full path label tooltip for workflow filter field#16580Devessier merged 6 commits intotwentyhq:mainfrom
Devessier merged 6 commits intotwentyhq:mainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-front/src/modules/workflow/workflow-variables/utils/searchVariableThroughFindRecordsOutputSchema.ts">
<violation number="1" location="packages/twenty-front/src/modules/workflow/workflow-variables/utils/searchVariableThroughFindRecordsOutputSchema.ts:48">
P2: Inconsistent handling: `stepNameLabel` is used for `first` and `totalCount` cases but not for the `all` case. This means users selecting "All Records" variables won't see the distinguishing full path tooltip, defeating the purpose of this feature for that variable type.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
...rc/modules/workflow/workflow-variables/utils/searchVariableThroughFindRecordsOutputSchema.ts
Show resolved
Hide resolved
…uckyGoyal039/twenty into workflow-duplicate-field-names
Contributor
Author
|
@Bonapara @Devessier, could I get a review for this PR? |
|
Hey @Devessier! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
abdulrahmancodes
pushed a commit
that referenced
this pull request
Dec 18, 2025
# Closes Issue: Can't distinguish between fields with identical names (#16285) There was a UX bug in the workflow filter interface where **two variables coming from different steps but sharing the same field name** were displayed identically. This made it difficult for users to tell them apart when used in a filter group, leading to confusion when building workflows. --- # Fix: Add Full Path Label Tooltip for Workflow Filter Field - Adds a **tooltip/label showing the complete path** so users can distinguish fields from different workflow steps even if they share the same name. ## UX Improvements <img width="495" height="288" alt="image" src="https://github.com/user-attachments/assets/fa26f381-835b-4d14-bf73-f04b59c8d0b5" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue: Can't distinguish between fields with identical names (#16285)
There was a UX bug in the workflow filter interface where two variables coming from different steps but sharing the same field name were displayed identically. This made it difficult for users to tell them apart when used in a filter group, leading to confusion when building workflows.
Fix: Add Full Path Label Tooltip for Workflow Filter Field
UX Improvements