[Dashboards] add hide empty category option for pie charts#16550
Merged
[Dashboards] add hide empty category option for pie charts#16550
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
128
to
135
| return { | ||
| data, | ||
| showLegend, | ||
| hasTooManyGroups: rawResults.length > PIE_CHART_MAXIMUM_NUMBER_OF_SLICES, | ||
| hasTooManyGroups: | ||
| filteredResults.length > PIE_CHART_MAXIMUM_NUMBER_OF_SLICES, | ||
| formattedToRawLookup, | ||
| }; | ||
| }; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bosiraphael
approved these changes
Dec 15, 2025
Contributor
bosiraphael
left a comment
bosiraphael
left a comment
There was a problem hiding this comment.
LGTM, just one comment to address before merging
...c/modules/page-layout/widgets/graph/graphWidgetPieChart/hooks/usePieChartCenterMetricData.ts
Show resolved
Hide resolved
|
Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
Contributor
|
Thanks @ehconitin for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://discord.com/channels/1130383047699738754/1445403391722520677
CleanShot.2025-12-14.at.19.13.01.mp4
toggle label ie
Hide empty category-- debatable