feat: 🎸 added higher resoulution options in the dateTime Filter#16548
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:44292 This environment will automatically shut down when the PR is closed or after 5 hours. |
|
Is that something we want to add in the UI @Bonapara ? (the more options, the messier it can feel) |
|
I think it is a great addition but:
|
|
Great. I will let you implement those feedback @Bhoomaahamso . But that's a great addition to our CRM. thanks for the work
|
|
Hi @Bonapara @guillim , For point 2, both |
-> ['Day', 'Week', 'Month', 'Year', 'Hour', 'Minute', 'Second']
-> yes please. in the same file will be fine. |
…at-add-detailed-time-options-to-date-time-filter
|
LGTM CleanShot.2025-12-17.at.14.37.57.mp4 |
Title: "feat: Add second, minute & hour resolution options to relative date Filter action" --- ## Summary This PR enables support for smaller time units — **Seconds, Minutes, and Hours** — in the *Relative Date* filter used in workflows, rather than being limited to days only. --- ## What Changed This PR extends the relative date filter to include support for the following units: ✔️ `SECOND` ✔️ `MINUTE` ✔️ `HOUR` ✔️ (Existing: `DAY`, `WEEK`, `MONTH`, etc.) Changes include: - Adding `SECOND`, `MINUTE`, and `HOUR` options to the internal relative date unit enum/constant. - Updating utility functions and parsers to correctly interpret and evaluate these new units. - Enhancing existing tests and adding new tests to cover second, minute, and hour relative filters. --- ## Testing New and updated tests include: - Unit tests for serialization of relative filter values including seconds, minutes, and hours. - Workflow filter evaluation tests that verify minute/hour resolution behaves correctly. Tests are included in the changeset. --- ## Backward Compatibility This change is fully backward compatible: - All existing relative date filters using days or larger units behave exactly as before. - Adding finer units does not alter existing stored data or workflow definitions. --- ## Issue Reference Fixes: **#15525** <img width="1909" height="896" alt="image" src="https://github.com/user-attachments/assets/328d03dc-ca0b-4c3f-84e5-58961c178398" /> --------- Co-authored-by: Guillim <guillim@users.noreply.github.com> Co-authored-by: guillim <guigloo@msn.com>
Title: "feat: Add second, minute & hour resolution options to relative date Filter action"
Summary
This PR enables support for smaller time units — Seconds, Minutes, and Hours — in the Relative Date filter used in workflows, rather than being limited to days only.
What Changed
This PR extends the relative date filter to include support for the following units:
✔️
SECOND✔️
MINUTE✔️
HOUR✔️ (Existing:
DAY,WEEK,MONTH, etc.)Changes include:
SECOND,MINUTE, andHOURoptions to the internal relative date unit enum/constant.Testing
New and updated tests include:
Tests are included in the changeset.
Backward Compatibility
This change is fully backward compatible:
Issue Reference
Fixes: #15525