fix: ensure deactivated object records do not appear in search#16532
Merged
etiennejouan merged 1 commit intomainfrom Dec 15, 2025
Merged
fix: ensure deactivated object records do not appear in search#16532etiennejouan merged 1 commit intomainfrom
etiennejouan merged 1 commit intomainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:13988 This environment will automatically shut down when the PR is closed or after 5 hours. |
etiennejouan
approved these changes
Dec 15, 2025
Contributor
etiennejouan
left a comment
etiennejouan
left a comment
There was a problem hiding this comment.
Hi @mabdullahabaid Thank you for your contribution ! 🙏 Looks good to me !
|
Hey @etiennejouan! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
Contributor
|
Thanks @mabdullahabaid for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deactivating an object still allowed querying its records in search.
This PR introduces a minor improvement to not query records of deactivated objects.