Merged
Conversation
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
Contributor
Author
LogDetails |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
17 issues found across 122 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all 17 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-front/src/locales/el-GR.po">
<violation number="1" location="packages/twenty-front/src/locales/el-GR.po:8589">
P2: Translation for "Short" is broken - it's set to a newline character instead of a proper Greek translation. Should be something like "Σύντομο" or "Σύντομη".</violation>
</file>
<file name="packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po">
<violation number="1" location="packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po:3074">
P2: Incorrect quote escaping. Using `\\\"` instead of `\"` will display literal backslashes before quotes in the UI. The translation should use `\"text\"` and `\"json\"` like other translations in this file.</violation>
<violation number="2" location="packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po:3079">
P2: Incorrect quote escaping. Using `\\\"` instead of `\"` will display literal backslashes before quotes in the UI.</violation>
<violation number="3" location="packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po:3084">
P2: Incorrect quote escaping. Using `\\\"` instead of `\"` will display literal backslashes before quotes in the UI.</violation>
</file>
<file name="packages/twenty-front/src/locales/af-ZA.po">
<violation number="1" location="packages/twenty-front/src/locales/af-ZA.po:1069">
P1: Translation contains corrupted/garbage characters that will display incorrectly to users. The string `'}]}```}``` }```{"` at the end appears to be malformed JSON or markdown artifacts and should be removed.</violation>
</file>
<file name="packages/twenty-front/src/locales/uk-UA.po">
<violation number="1" location="packages/twenty-front/src/locales/uk-UA.po:5459">
P2: The translation for "items" keeps the English word instead of providing a Ukrainian translation. This should be translated to the appropriate Ukrainian word (e.g., "елементів", "елементи", or "позиції" depending on context).</violation>
</file>
<file name="packages/twenty-server/src/engine/core-modules/i18n/locales/sv-SE.po">
<violation number="1" location="packages/twenty-server/src/engine/core-modules/i18n/locales/sv-SE.po:2241">
P2: Translation for "Monday" contains an embedded newline creating broken text "M\nndags" instead of "Måndag".</violation>
<violation number="2" location="packages/twenty-server/src/engine/core-modules/i18n/locales/sv-SE.po:3186">
P2: Translation for "Saturday" contains an embedded newline creating broken text "L\nurdag" instead of "Lördag".</violation>
<violation number="3" location="packages/twenty-server/src/engine/core-modules/i18n/locales/sv-SE.po:3331">
P1: Translation for "Sunday" contains an embedded newline and is also incorrect - "S\nnd" should be "Söndag".</violation>
</file>
<file name="packages/twenty-server/src/engine/core-modules/i18n/locales/zh-TW.po">
<violation number="1" location="packages/twenty-server/src/engine/core-modules/i18n/locales/zh-TW.po:3074">
P2: Incorrect escape sequence for quotes in translation. Using `\\\"` instead of `\"` will cause the quotes to render incorrectly in the UI.</violation>
<violation number="2" location="packages/twenty-server/src/engine/core-modules/i18n/locales/zh-TW.po:3079">
P2: Incorrect escape sequence for quotes in translation. Using `\\\"` instead of `\"` will cause the quotes to render incorrectly.</violation>
<violation number="3" location="packages/twenty-server/src/engine/core-modules/i18n/locales/zh-TW.po:3084">
P2: Incorrect escape sequence for quotes in translation. Using `\\\"` instead of `\"` will cause the quotes to render incorrectly.</violation>
</file>
<file name="packages/twenty-front/src/locales/ro-RO.po">
<violation number="1" location="packages/twenty-front/src/locales/ro-RO.po:4668">
P2: Translation for 'Gauge Chart' may be inaccurate. 'Grafic tip ceas' translates to 'clock-type chart', but a gauge chart is a speedometer/dial visualization, not a clock. Consider using 'Grafic indicator' or 'Grafic de tip indicator' instead.</violation>
</file>
<file name="packages/twenty-server/src/engine/core-modules/i18n/locales/vi-VN.po">
<violation number="1" location="packages/twenty-server/src/engine/core-modules/i18n/locales/vi-VN.po:205">
P2: Translation inconsistency: 'Agent not found' uses 'đại lý' (business agent) while all other agent-related translations in this file use 'tác nhân' (technical agent). Should use 'Không tìm thấy tác nhân' for consistency.</violation>
</file>
<file name="packages/twenty-front/src/locales/de-DE.po">
<violation number="1" location="packages/twenty-front/src/locales/de-DE.po:5459">
P2: Untranslated string: "items" should be translated to German (e.g., "Elemente" or "Einträge").</violation>
<violation number="2" location="packages/twenty-front/src/locales/de-DE.po:7913">
P2: German nouns must be capitalized. "rolle" should be "Rolle".</violation>
</file>
<file name="packages/twenty-front/src/locales/da-DK.po">
<violation number="1" location="packages/twenty-front/src/locales/da-DK.po:5699">
P2: Inconsistent compound word formation. In Danish, compound nouns should be written as single words. "Linje Diagram" should be "Linjediagram" to be consistent with "Målediagram" (Gauge Chart) and "Cirkeldiagram" (Pie Chart).</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| msgid "Short" | ||
| msgstr "" | ||
| "\n" | ||
| msgstr "\n" |
Contributor
There was a problem hiding this comment.
P2: Translation for "Short" is broken - it's set to a newline character instead of a proper Greek translation. Should be something like "Σύντομο" or "Σύντομη".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/el-GR.po, line 8589:
<comment>Translation for "Short" is broken - it's set to a newline character instead of a proper Greek translation. Should be something like "Σύντομο" or "Σύντομη".</comment>
<file context>
@@ -8586,8 +8586,7 @@ msgstr "Μοιραστείτε αυτόν τον σύνδεσμο για να π
msgid "Short"
-msgstr ""
-"\n"
+msgstr "\n"
"��"
</file context>
|
|
||
| #. js-lingui-id: JCqfz6 | ||
| #: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/utils/validate-agent-response-format.util.ts | ||
| msgid "Response format with type \"text\" should not include a schema" | ||
| msgstr "" | ||
| msgstr "種類が \\\"text\\\" のレスポンス形式にスキーマを含めるべきではありません" |
Contributor
There was a problem hiding this comment.
P2: Incorrect quote escaping. Using \\\" instead of \" will display literal backslashes before quotes in the UI.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po, line 3084:
<comment>Incorrect quote escaping. Using `\\\"` instead of `\"` will display literal backslashes before quotes in the UI.</comment>
<file context>
@@ -3071,17 +3071,17 @@ msgstr "リクエストの期限が切れています。再試行してくださ
#: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/utils/validate-agent-response-format.util.ts
msgid "Response format with type \"text\" should not include a schema"
-msgstr ""
+msgstr "種類が \\\"text\\\" のレスポンス形式にスキーマを含めるべきではありません"
#. js-lingui-id: rnCndp
</file context>
Suggested change
| msgstr "種類が \\\"text\\\" のレスポンス形式にスキーマを含めるべきではありません" | |
| msgstr "種類が \"text\" のレスポンス形式にスキーマを含めるべきではありません" |
|
|
||
| #. js-lingui-id: 6Plp3x | ||
| #: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/utils/validate-agent-response-format.util.ts | ||
| msgid "Response format with type \"json\" must include a schema" | ||
| msgstr "" | ||
| msgstr "種類が \\\"json\\\" のレスポンス形式にはスキーマを含める必要があります" |
Contributor
There was a problem hiding this comment.
P2: Incorrect quote escaping. Using \\\" instead of \" will display literal backslashes before quotes in the UI.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po, line 3079:
<comment>Incorrect quote escaping. Using `\\\"` instead of `\"` will display literal backslashes before quotes in the UI.</comment>
<file context>
@@ -3071,17 +3071,17 @@ msgstr "リクエストの期限が切れています。再試行してくださ
#: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/utils/validate-agent-response-format.util.ts
msgid "Response format with type \"json\" must include a schema"
-msgstr ""
+msgstr "種類が \\\"json\\\" のレスポンス形式にはスキーマを含める必要があります"
#. js-lingui-id: JCqfz6
</file context>
Suggested change
| msgstr "種類が \\\"json\\\" のレスポンス形式にはスキーマを含める必要があります" | |
| msgstr "種類が \"json\" のレスポンス形式にはスキーマを含める必要があります" |
| @@ -3071,17 +3071,17 @@ msgstr "リクエストの期限が切れています。再試行してくださ | |||
| #. js-lingui-id: KPIUoa | |||
| #: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/utils/validate-agent-response-format.util.ts | |||
| msgid "Response format type must be either \"text\" or \"json\"" | |||
| msgstr "" | |||
| msgstr "レスポンス形式の種類は、\\\"text\\\" または \\\"json\\\" のいずれかでなければなりません" | |||
Contributor
There was a problem hiding this comment.
P2: Incorrect quote escaping. Using \\\" instead of \" will display literal backslashes before quotes in the UI. The translation should use \"text\" and \"json\" like other translations in this file.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-server/src/engine/core-modules/i18n/locales/ja-JP.po, line 3074:
<comment>Incorrect quote escaping. Using `\\\"` instead of `\"` will display literal backslashes before quotes in the UI. The translation should use `\"text\"` and `\"json\"` like other translations in this file.</comment>
<file context>
@@ -3071,17 +3071,17 @@ msgstr "リクエストの期限が切れています。再試行してくださ
#: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/utils/validate-agent-response-format.util.ts
msgid "Response format type must be either \"text\" or \"json\""
-msgstr ""
+msgstr "レスポンス形式の種類は、\\\"text\\\" または \\\"json\\\" のいずれかでなければなりません"
#. js-lingui-id: 6Plp3x
</file context>
Suggested change
| msgstr "レスポンス形式の種類は、\\\"text\\\" または \\\"json\\\" のいずれかでなければなりません" | |
| msgstr "レスポンス形式の種類は、\"text\" または \"json\" のいずれかでなければなりません" |
| #: src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/HttpRequestExecutionResult.tsx | ||
| msgid "An error occurred" | ||
| msgstr "" | ||
| msgstr "'n Fout het voorgekom'}]}```}``` }```{" |
Contributor
There was a problem hiding this comment.
P1: Translation contains corrupted/garbage characters that will display incorrectly to users. The string '}]}```}``` }```{" at the end appears to be malformed JSON or markdown artifacts and should be removed.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/af-ZA.po, line 1069:
<comment>Translation contains corrupted/garbage characters that will display incorrectly to users. The string `'}]}```}``` }```{"` at the end appears to be malformed JSON or markdown artifacts and should be removed.</comment>
<file context>
@@ -1066,7 +1066,7 @@ msgstr "Laat toe dat gebruikers aanmeld met 'n e-pos en wagwoord."
#: src/modules/workflow/workflow-steps/workflow-actions/http-request-action/components/HttpRequestExecutionResult.tsx
msgid "An error occurred"
-msgstr ""
+msgstr "'n Fout het voorgekom'}]}```}``` }```{"
#. js-lingui-id: VD5bNu
</file context>
Suggested change
| msgstr "'n Fout het voorgekom'}]}```}``` }```{" | |
| msgstr "'n Fout het voorgekom" |
| #: src/modules/command-menu/pages/page-layout/constants/GraphTypeInformation.ts | ||
| msgid "Gauge Chart" | ||
| msgstr "" | ||
| msgstr "Grafic tip ceas" |
Contributor
There was a problem hiding this comment.
P2: Translation for 'Gauge Chart' may be inaccurate. 'Grafic tip ceas' translates to 'clock-type chart', but a gauge chart is a speedometer/dial visualization, not a clock. Consider using 'Grafic indicator' or 'Grafic de tip indicator' instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/ro-RO.po, line 4668:
<comment>Translation for 'Gauge Chart' may be inaccurate. 'Grafic tip ceas' translates to 'clock-type chart', but a gauge chart is a speedometer/dial visualization, not a clock. Consider using 'Grafic indicator' or 'Grafic de tip indicator' instead.</comment>
<file context>
@@ -4665,7 +4665,7 @@ msgstr "Funcții - Setări"
#: src/modules/command-menu/pages/page-layout/constants/GraphTypeInformation.ts
msgid "Gauge Chart"
-msgstr ""
+msgstr "Grafic tip ceas"
#. js-lingui-id: Weq9zb
</file context>
| @@ -202,12 +202,12 @@ msgstr "Địa chỉ của công ty - không còn được sử dụng nữa, th | |||
| #: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-agent-validator.service.ts | |||
| #: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-agent-validator.service.ts | |||
| msgid "Agent not found" | |||
| msgstr "" | |||
| msgstr "Không tìm thấy đại lý" | |||
Contributor
There was a problem hiding this comment.
P2: Translation inconsistency: 'Agent not found' uses 'đại lý' (business agent) while all other agent-related translations in this file use 'tác nhân' (technical agent). Should use 'Không tìm thấy tác nhân' for consistency.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-server/src/engine/core-modules/i18n/locales/vi-VN.po, line 205:
<comment>Translation inconsistency: 'Agent not found' uses 'đại lý' (business agent) while all other agent-related translations in this file use 'tác nhân' (technical agent). Should use 'Không tìm thấy tác nhân' for consistency.</comment>
<file context>
@@ -202,12 +202,12 @@ msgstr "Địa chỉ của công ty - không còn được sử dụng nữa, th
#: src/engine/workspace-manager/workspace-migration-v2/workspace-migration-builder-v2/validators/services/flat-agent-validator.service.ts
msgid "Agent not found"
-msgstr ""
+msgstr "Không tìm thấy đại lý"
#. js-lingui-id: EisfDV
</file context>
Suggested change
| msgstr "Không tìm thấy đại lý" | |
| msgstr "Không tìm thấy tác nhân" |
| #: src/modules/command-menu/pages/page-layout/utils/getDateGranularityPluralLabel.ts | ||
| msgid "items" | ||
| msgstr "" | ||
| msgstr "items" |
Contributor
There was a problem hiding this comment.
P2: Untranslated string: "items" should be translated to German (e.g., "Elemente" or "Einträge").
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/de-DE.po, line 5459:
<comment>Untranslated string: "items" should be translated to German (e.g., "Elemente" or "Einträge").</comment>
<file context>
@@ -5456,7 +5456,7 @@ msgstr "Italienisch"
#: src/modules/command-menu/pages/page-layout/utils/getDateGranularityPluralLabel.ts
msgid "items"
-msgstr ""
+msgstr "items"
#. js-lingui-id: +qz/bj
</file context>
Suggested change
| msgstr "items" | |
| msgstr "Elemente" |
| #: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts | ||
| msgid "role" | ||
| msgstr "" | ||
| msgstr "rolle" |
Contributor
There was a problem hiding this comment.
P2: German nouns must be capitalized. "rolle" should be "Rolle".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/de-DE.po, line 7913:
<comment>German nouns must be capitalized. "rolle" should be "Rolle".</comment>
<file context>
@@ -7910,7 +7910,7 @@ msgstr "Zurückgezogen für dieses Objekt"
#: src/modules/metadata-error-handler/hooks/useMetadataErrorHandler.ts
msgid "role"
-msgstr ""
+msgstr "rolle"
#. js-lingui-id: GDvlUT
</file context>
Suggested change
| msgstr "rolle" | |
| msgstr "Rolle" |
| #: src/modules/command-menu/pages/page-layout/constants/GraphTypeInformation.ts | ||
| msgid "Line Chart" | ||
| msgstr "" | ||
| msgstr "Linje Diagram" |
Contributor
There was a problem hiding this comment.
P2: Inconsistent compound word formation. In Danish, compound nouns should be written as single words. "Linje Diagram" should be "Linjediagram" to be consistent with "Målediagram" (Gauge Chart) and "Cirkeldiagram" (Pie Chart).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/locales/da-DK.po, line 5699:
<comment>Inconsistent compound word formation. In Danish, compound nouns should be written as single words. "Linje Diagram" should be "Linjediagram" to be consistent with "Målediagram" (Gauge Chart) and "Cirkeldiagram" (Pie Chart).</comment>
<file context>
@@ -5696,7 +5696,7 @@ msgstr ""
#: src/modules/command-menu/pages/page-layout/constants/GraphTypeInformation.ts
msgid "Line Chart"
-msgstr ""
+msgstr "Linje Diagram"
#. js-lingui-id: pQjjYo
</file context>
Suggested change
| msgstr "Linje Diagram" | |
| msgstr "Linjediagram" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Github action