feat(ai): replace agent search with skills system#16513
Merged
FelixMalfait merged 2 commits intomainfrom Dec 12, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 21 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/twenty-server/src/engine/core-modules/skills/skills.service.ts">
<violation number="1" location="packages/twenty-server/src/engine/core-modules/skills/skills.service.ts:5">
P2: The `Skill` type duplicates `SkillDefinition` from `./skill-definitions`. Consider reusing the existing type to avoid maintenance issues if the shape changes.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
|
|
||
| import { SKILL_DEFINITIONS } from './skill-definitions'; | ||
|
|
||
| export type Skill = { |
Contributor
There was a problem hiding this comment.
P2: The Skill type duplicates SkillDefinition from ./skill-definitions. Consider reusing the existing type to avoid maintenance issues if the shape changes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-server/src/engine/core-modules/skills/skills.service.ts, line 5:
<comment>The `Skill` type duplicates `SkillDefinition` from `./skill-definitions`. Consider reusing the existing type to avoid maintenance issues if the shape changes.</comment>
<file context>
@@ -0,0 +1,43 @@
+
+import { SKILL_DEFINITIONS } from './skill-definitions';
+
+export type Skill = {
+ name: string;
+ label: string;
</file context>
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:4386 This environment will automatically shut down when the PR is closed or after 5 hours. |
- Add skills module with predefined skill definitions (workflow-building, data-manipulation, dashboard-building, metadata-building, research) - Replace agent_search tool with load_skill tool for explicit skill loading - Remove specialized agents, keep only helper agent - Add skill catalog to system prompt with names and descriptions - Add recordReferences to workflow creation for chip linking
FelixMalfait
force-pushed
the
feat/replace-agents-with-skills
branch
2 times, most recently
from
fa6b5ae to
c7744d2
Compare
FelixMalfait
force-pushed
the
feat/replace-agents-with-skills
branch
from
c7744d2 to
737ccf9
Compare
|
Hey @FelixMalfait! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
prastoin
added a commit
that referenced
this pull request
Dec 16, 2025
# Introduction In this pullrequest have been migrated to the flat standard entities: Role, Agent and RoleTargets. ## What happens - Removed createStandardMorph tool util in favor of dynamic typing of `createMorphOrRelationStandardField` - Implemented a command to remove standard agents and their role that has been removed in #16513 also added a default role target to data manipulator role to the only remaining agent - Implemented an agent deleteMany service handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillsmodule with predefined skill definitions that the AI can load on demandrecordReferencesto workflow creation tool for chip linking in the UIChanges
New Skills Module
skill-definitions.ts- Contains 5 skill definitions with detailed instructionsskills.service.ts- Service to get skills by nameload-skill.tool.ts- Tool for AI to load skills explicitlyRemoved
agent-search.tool.ts- Replaced by skill loadingUpdated
recordReferencesfor UI linkingTest plan
load_skilltool