Skip to content

Implement hide empty groups for grouped table view #16494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FelixMalfait merged 9 commits into from
Jan 9, 2026
Merged

Implement hide empty groups for grouped table view #16494

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3af080c
Refactor Record Table Group Rendering
abdulrahmancodes Dec 11, 2025
0aaa32f
Refactor Record Table Group Rendering
abdulrahmancodes Dec 11, 2025
125fbfe
Add filteredVisibleRecordGroupIdsComponentFamilySelector
abdulrahmancodes Dec 11, 2025
e45bef6
Refactor Record Board Components to Use Filtered Selector
abdulrahmancodes Dec 16, 2025
2f7ffe5
Merge branch 'main' into feat/hide-empty-groups-table-view
abdulrahmancodes Dec 16, 2025
442e2cd
Merge branch 'main' into feat/hide-empty-groups-table-view
FelixMalfait Jan 7, 2026
a82a847
Merge branch 'main' into feat/hide-empty-groups-table-view
FelixMalfait Jan 7, 2026
32a07ba
Remove selector pattern
FelixMalfait Jan 8, 2026
a7aee5b
Merge branch 'main' into feat/hide-empty-groups-table-view
FelixMalfait Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions ...s/object-record/record-table/record-table-body/components/RecordTableRecordGroupsBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import { useRecoilCallback } from 'recoil';

import { RecordGroupContext } from '@/object-record/record-group/states/context/RecordGroupContext';
import { visibleRecordGroupIdsComponentFamilySelector } from '@/object-record/record-group/states/selectors/visibleRecordGroupIdsComponentFamilySelector';
import { RecordIndexGroupAggregatesDataLoader } from '@/object-record/record-index/components/RecordIndexGroupAggregatesDataLoader';
import { recordIndexRecordIdsByGroupComponentFamilyState } from '@/object-record/record-index/states/recordIndexRecordIdsByGroupComponentFamilyState';
import { recordIndexShouldHideEmptyRecordGroupsComponentState } from '@/object-record/record-index/states/recordIndexShouldHideEmptyRecordGroupsComponentState';
import { recordIndexAllRecordIdsComponentSelector } from '@/object-record/record-index/states/selectors/recordIndexAllRecordIdsComponentSelector';
import { RecordTableRecordGroupBodyContextProvider } from '@/object-record/record-table/components/RecordTableRecordGroupBodyContextProvider';
import { RecordTableRecordGroupRows } from '@/object-record/record-table/components/RecordTableRecordGroupRows';
Expand All @@ -10,8 +14,10 @@ import { RecordTableBodyRecordGroupDroppable } from '@/object-record/record-tabl
import { RecordTableCellPortals } from '@/object-record/record-table/record-table-cell/components/RecordTableCellPortals';
import { RecordTableRecordGroupSection } from '@/object-record/record-table/record-table-section/components/RecordTableRecordGroupSection';
import { isRecordTableInitialLoadingComponentState } from '@/object-record/record-table/states/isRecordTableInitialLoadingComponentState';
import { useRecoilComponentFamilyCallbackState } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentFamilyCallbackState';
import { useRecoilComponentFamilyValue } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentFamilyValue';
import { useRecoilComponentValue } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValue';
import { getSnapshotValue } from '@/ui/utilities/state/utils/getSnapshotValue';
import { ViewType } from '@/views/types/ViewType';

export const RecordTableRecordGroupsBody = () => {
Expand All @@ -28,17 +34,51 @@ export const RecordTableRecordGroupsBody = () => {
ViewType.Table,
);

const shouldHideEmptyRecordGroups = useRecoilComponentValue(
recordIndexShouldHideEmptyRecordGroupsComponentState,
);

const recordIndexRecordIdsByGroupFamilyState =
useRecoilComponentFamilyCallbackState(
recordIndexRecordIdsByGroupComponentFamilyState,
);

const getFilteredRecordGroupIds = useRecoilCallback(
({ snapshot }) =>
() => {
if (!shouldHideEmptyRecordGroups) {
return visibleRecordGroupIds;
}

return visibleRecordGroupIds.filter((recordGroupId) => {
const recordIdsByGroup = getSnapshotValue(
snapshot,
recordIndexRecordIdsByGroupFamilyState(recordGroupId),
);

return recordIdsByGroup.length > 0;
});
},
[
shouldHideEmptyRecordGroups,
visibleRecordGroupIds,
recordIndexRecordIdsByGroupFamilyState,
],
);

const filteredGroupIds = getFilteredRecordGroupIds();

if (isRecordTableInitialLoading && allRecordIds.length === 0) {
return <RecordTableBodyLoading />;
}

return (
<>
<RecordTableBodyRecordGroupDragDropContextProvider>
{visibleRecordGroupIds.map((recordGroupId, index) => (
{filteredGroupIds.map((recordGroupId, index) => (
<RecordTableRecordGroupBodyContextProvider
key={recordGroupId}
recordGroupId={recordGroupId}
key={recordGroupId}
>
<RecordGroupContext.Provider value={{ recordGroupId }}>
<RecordTableBodyRecordGroupDroppable
Expand Down
Loading